Review main Merged

72910[BUGFIX] Bring back functionality for $uniqueIds in SelectSingleElement

Nikita Hovratov CR +2 V +2 Easy +8 −7 updated 03/28/22, 14:03

Commit message

This resolves a todo for a missing usage of a filled
array called "$uniqueIds".

This array had two responsibilities:

1. For inline fields with "foreign_unique" set, all
already used unique ids must be excluded from the
select items.

2. Ensure a select field inside an inline field,
which functions as one (symmetric) side of a
mn-table, will not have the same field we are
currently in, in its select items. In short: This
prevents self-references.

The previous functionality has been restored with
added type-safety.

This functionality was probably removed by accident
during a refactoring process.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 2532

Show 57 earlier messages
  1. Nikita Hovratov uploaded patch set 1 01/07/22, 23:01

  2. Nikita Hovratov commented on patch set 1 01/07/22, 23:03

  3. core-ci voted on patch set 1 V -1 01/07/22, 23:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21798

  4. Nikita Hovratov uploaded patch set 2 01/07/22, 23:07

  5. core-ci voted on patch set 2 V +1 01/07/22, 23:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21799

  6. Christian Kuhn commented on patch set 2 01/08/22, 11:42

    SelectSingleElement.php:96

    maybe change this comment to explain what is and why it is happening here?
  7. Nikita Hovratov uploaded patch set 3 01/08/22, 16:08

  1. Nikita Hovratov commented on patch set 3 01/08/22, 16:09

    SelectSingleElement.php:96 Reply

    Done
  2. core-ci voted on patch set 3 V +1 01/08/22, 16:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21812

  3. Benni Mack voted on patch set 3 CR +1 01/09/22, 13:27

  4. Wouter Wolters voted on patch set 3 CR +1 01/10/22, 19:17

  5. Nikita Hovratov commented on patch set 3 V -1 CR -1 01/11/22, 14:43

    This needs some further investigations.
  6. Nikita Hovratov uploaded patch set 4 01/11/22, 14:52

  7. core-ci voted on patch set 4 V +1 01/11/22, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21912

  8. Nikita Hovratov commented on patch set 4 01/17/22, 19:16

    Ready for review.
  9. Nikita Hovratov rebased onto patch set 5 02/14/22, 08:58

  10. core-ci voted on patch set 5 V +1 02/14/22, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23491

  11. Christian Kuhn commented on patch set 5 02/14/22, 11:35

    is this reproducible with styleguide?
  12. Nikita Hovratov commented on patch set 5 02/14/22, 11:54

    Reply

    Yes, with a few modifications. Case 1: /typo3/record/edit?edit[tx_styleguide_inline_mnsymmetric][1]=edit Case 2: /typo3/record/edit?edit[tx_styleguide_inline_mngroup_child][1]=edit Case 2 needs this modification (needs select instead of group): 'parentid' => [ 'label' => 'parentid', 'config' => [ 'type' => 'select', 'renderType' => 'selectSingle', 'size' => 1, 'eval' => 'int', 'maxitems' => 1, 'minitems' => 0, 'foreign_table' => 'tx_styleguide_inline_mngroup', 'hideSuggest' => true, 'fieldWizard' => [ 'recordsOverview' => [ 'disabled' => true, ], ], ] ],
  13. Nikita Hovratov commented on patch set 5 02/14/22, 11:55

    Reply

    Modification in tx_styleguide_inline_mngroup_mm.php
  14. Nikita Hovratov rebased onto patch set 6 02/18/22, 18:45

  15. core-ci voted on patch set 6 V +1 02/18/22, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23891

  16. Stefan Bürk voted on patch set 6 V +1 CR +1 03/06/22, 18:13

  17. Nikita Hovratov rebased onto patch set 7 03/24/22, 17:18

  18. Nikita Hovratov commented on patch set 7 03/24/22, 17:18

    rebased. please re-vote.
  19. core-ci voted on patch set 7 V +1 03/24/22, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25109

  20. Tymoteusz Motylewski commented on patch set 7 03/26/22, 20:18

    shouldnt this got an example in styleguide and a acc test?
  21. Nikita Hovratov commented on patch set 7 03/27/22, 14:35

    Reply

    Scenario 1 yes, 2 no. The second one can be tested with a small adjustment in styleguide though, which I described in the issue. Acc test would be great of course.
  22. Christian Kuhn voted on patch set 7 V +1 CR +1 03/28/22, 13:34

  23. Stefan Bürk voted on patch set 7 V +1 CR +1 03/28/22, 13:37

  24. Christian Kuhn commented on patch set 7 V +2 CR +2 03/28/22, 14:03

    nifty and not *that* easy to replay. thanks to Nikita, who guided stefan and me through this. this should be safe.
  25. Christian Kuhn merged patch set 8 03/28/22, 14:03