72918[BUGFIX] Prevent redirects causing infinite redirect loops
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/redirects/Classes/Http/Middleware/RedirectHandler.php+77 −1
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/RedirectService_samePathRedirectsWithExternalTarget.csvnew+27 −0
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/RedirectService_samePathWithSameDomainAndRelativeTarget.csvnew+23 −0
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/RedirectService_samePathWithSameDomainT3Target.csvnew+23 −0
- typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php+470 −0
Review log 68
-
Benni Mack commented on patch set 1 01/07/22, 12:52
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/redirects/Classes/Http/Middleware/RedirectHandler.php -
Benni Mack marked it ready for review 01/07/22, 12:52
-
Benni Mack commented on patch set 2 01/07/22, 12:54
Published edit on patch set 1. -
core-ci voted on patch set 1 V -1 01/07/22, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21767
-
core-ci voted on patch set 2 V +1 01/07/22, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21768
-
Stefan Bürk voted on patch set 2 V +1 CR +1 01/07/22, 13:09
-
Benni Mack voted on patch set 2 V +2 CR +2 01/07/22, 13:34
-
Benni Mack merged patch set 3 01/07/22, 13:35