Review 11.5 Merged

72918[BUGFIX] Prevent redirects causing infinite redirect loops

Benni Mack CR +2 V +2 Hard +620 −1 updated 01/07/22, 13:35

Commit message

This patch adds a check to detect self referencing
redirects, thus avoiding them and instead log an error
in the corresponding frontend redirect middleware.

Furthermore, add a bunch of tests along the way to cover
this change and the different constellations, for example
not avoiding redirect with the same path but external host.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 68

  1. Benni Mack commented on patch set 1 01/07/22, 12:52

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/redirects/Classes/Http/Middleware/RedirectHandler.php
  2. Benni Mack marked it ready for review 01/07/22, 12:52

  3. Benni Mack commented on patch set 2 01/07/22, 12:54

    Published edit on patch set 1.
  4. core-ci voted on patch set 1 V -1 01/07/22, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21767

  5. core-ci voted on patch set 2 V +1 01/07/22, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21768

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 01/07/22, 13:09

  7. Benni Mack voted on patch set 2 V +2 CR +2 01/07/22, 13:34

  8. Benni Mack merged patch set 3 01/07/22, 13:35