Review 10.4 Merged

72932[BUGFIX] Fix NavigationContainer iframe loading

Benjamin Franzke CR +2 V +2 Easy +5 −11 updated 01/10/22, 16:24

Commit message

Some browsers (reported were Safari and Firefox) are not able to
load the file tree when invoking the module the first time.
This is because the iframe src is initially set to about:blank
and ModuleMenu calls both, iframe.setAttribute('src', …) and
iframe.contentWindow.location.reload(). This seems to cause
browsers to abort load as the current URL is being reloaded.

This is actually a result of a refactoring in #52877 where
the condition navUrl != currentUrl previously correctly
issued a `setUrl()` call but afterwards was swapped to
call `refresh()` instead (or rather additionally).

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 45

  1. Benjamin Franzke uploaded patch set 1 01/08/22, 09:28

  2. core-ci voted on patch set 1 V +1 01/08/22, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21804

  3. Andreas Kienast commented on patch set 1 V +1 CR +1 01/08/22, 13:00

    A lot cleaner than my other approach, thanks for taking care!
  4. Oliver Hader voted on patch set 1 V +2 CR +2 01/10/22, 16:23

  5. Oliver Hader merged patch set 2 01/10/22, 16:24