Review main Merged

72936[TASK] Unify TSFE usage consistently in HMENU

Benni Mack CR +2 V +2 Easy +10 −10 updated 01/10/22, 15:55

Commit message

Some code in HMENU stems back from TYPO3 v3.x days,
and this code aims to streamline the functionality
given current functionality.

HMENU now has its own sys_page object, which should
be used. In addition, HMENU should fetch TSFE->id
consistently across all its code base.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1216

  1. Benni Mack uploaded patch set 1 01/09/22, 13:18

  2. core-ci voted on patch set 1 V -1 01/09/22, 13:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21824

  3. Benni Mack uploaded patch set 2 01/10/22, 08:20

  4. core-ci voted on patch set 2 V +1 01/10/22, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21829

  5. Benni Mack updated the commit message in patch set 3 01/10/22, 09:06

  6. core-ci voted on patch set 3 V +1 01/10/22, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21830

  7. Stefan Bürk voted on patch set 3 V +1 CR +1 01/10/22, 12:25

  8. Oli Bartsch commented on patch set 3 V +1 CR +1 01/10/22, 13:57

    AbstractMenuContentObject.php:320

    We could add a string cast here since this might be an int.
  9. Benni Mack commented on patch set 3 01/10/22, 13:59

    AbstractMenuContentObject.php:320 Reply

    PHP Stan did not complain :)
  10. Benni Mack commented on patch set 4 01/10/22, 14:00

    Published edit on patch set 3.
  11. Benni Mack commented on patch set 4 01/10/22, 14:00

    AbstractMenuContentObject.php:320 Reply

    Done
  12. Oli Bartsch commented on patch set 4 V +1 CR +1 01/10/22, 14:00

    AbstractMenuContentObject.php:320 Reply

    Done
  13. core-ci voted on patch set 4 V +1 01/10/22, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21856

  14. Stefan Bürk voted on patch set 4 V +1 CR +1 01/10/22, 15:36

  15. Benni Mack voted on patch set 4 V +2 CR +2 01/10/22, 15:55

  16. Benni Mack merged patch set 5 01/10/22, 15:55