Review main Merged

72938[TASK] Update CKEditor to v4.17.1

Oliver Hader CR +2 V +2 Nightmare +1440 −2745 updated 01/10/22, 17:22

Commit message

Update to CKEditor v4.17.1 which addressed browser compatibility
issues and known security vulnerabilities:

https://ckeditor.com/cke4/release-notes

Commands:
  rm -r typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib
  cd Build
  yarn add 'ckeditor4@^4.17.1'
  yarn build

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 451

Show 431 more files

Review log 911

  1. Oliver Hader uploaded patch set 1 01/10/22, 10:45

  2. Benjamin Franzke commented on patch set 1 01/10/22, 10:56

    Hey, there are a bunch of plugins that seem to no longer be included in ckeditor. If I run: cd Build rm -rf ../typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/ yarn build git status | grep gelöscht | grep -v lang/ Then the following files are not re-created which means they are no longer part of ckeditor sources. I don't know though whether we need to treat these as API (of us) or whether we can simply remove them? gelöscht: ../typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/plugins/ajax/plugin.js gelöscht: ../typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/plugins/filetools/plugin.js gelöscht: ../typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/plugins/flash/dialogs/flash.js gelöscht: ../typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/plugins/flash/icons/flash.png gelöscht: ../typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/plugins/flash/icons/hidpi/flash.png gelöscht: ../typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/plugins/flash/images/placeholder.png gelöscht: ../typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/plugins/lineutils/plugin.js gelöscht: ../typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/plugins/notification/plugin.js gelöscht: ../typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/plugins/notificationaggregator/plugin.js gelöscht: ../typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/plugins/uicolor/yui/assets/hue_bg.png gelöscht: ../typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/plugins/uicolor/yui/assets/hue_thumb.png gelöscht: ../typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/plugins/uicolor/yui/assets/picker_mask.png gelöscht: ../typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/plugins/uicolor/yui/assets/picker_thumb.png gelöscht: ../typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/plugins/uicolor/yui/assets/yui.css gelöscht: ../typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/plugins/uicolor/yui/yui.js gelöscht: ../typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/plugins/uploadimage/plugin.js gelöscht: ../typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/plugins/uploadwidget/plugin.js gelöscht: ../typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/plugins/widget/plugin.js gelöscht: ../typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/plugins/widgetselection/plugin.js gelöscht: ../typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/plugins/xml/plugin.js
  3. core-ci voted on patch set 1 V +1 01/10/22, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21834

  4. Oliver Hader voted on patch set 1 CR -1 01/10/22, 13:00

  5. Oliver Hader uploaded patch set 2 01/10/22, 13:03

  6. core-ci voted on patch set 2 V +1 01/10/22, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21854

  7. Benjamin Franzke voted on patch set 2 CR +1 01/10/22, 13:22

  8. Benjamin Franzke commented on patch set 2 V +1 01/10/22, 13:25

    Note: Some plugins have been moved into ckeditor core, therefore th fine to remove the (unused) module files.
  9. Benni Mack voted on patch set 2 V +1 CR +1 01/10/22, 15:54

  10. Andreas Kienast voted on patch set 2 V +2 CR +2 01/10/22, 17:22

  11. Andreas Kienast merged patch set 3 01/10/22, 17:22