Review main Merged Breaking

72939[!!!][TASK] Remove HMENU.collapse option

Benni Mack CR +2 V +2 Easy +41 −9 updated 01/12/22, 11:27

Commit message

When the "collapse" option in the HMENU ContentObject
is activated, any active page links to its actual parent
page. This option was never touched since TYPO3 4.0
and stems from the time when TYPO3 still included JSMENU
and GMENU_LAYERS functionalities, which is not needed anymore
as more modern solutions such as MenuProcessor for Fluid
are more-widespread.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 710

  1. Benni Mack uploaded patch set 1 01/10/22, 10:48

  2. core-ci voted on patch set 1 V +1 01/10/22, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21835

  3. Benni Mack updated the commit message in patch set 2 01/11/22, 21:52

  4. core-ci voted on patch set 2 V +1 01/11/22, 22:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21943

  5. Benni Mack uploaded patch set 3 01/12/22, 10:16

  6. Christian Kuhn voted on patch set 3 V +1 CR +1 01/12/22, 10:18

  7. core-ci voted on patch set 3 V +1 01/12/22, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21953

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 01/12/22, 11:27

  9. Christian Kuhn voted on patch set 3 V +2 CR +2 01/12/22, 11:27

  10. Christian Kuhn merged patch set 4 01/12/22, 11:27