Review main Abandoned

72943[TASK] Update jquery-ui to v1.13.2

Oliver Hader CR 0 V 0 Easy +18 −26 updated 10/03/22, 15:16

Commit message

Update to jquery-ui v1.13.2 which addressed lots of browser
compatibility topics and known security vulnerabilities.
The currently used version 1.11.4 has been released in 2015(!).

https://blog.jqueryui.com/2016/09/jquery-ui-1-12-1/
https://blog.jqueryui.com/2021/10/jquery-ui-1-13-0-released/

Commands:
  cd Build/
  npm add --save 'jquery-ui@^1.13.2'
  npm run build

At least since TYPO3 v10 none of the known jquery-ui vulnerabilities
have been linked or used at all - however automated scanners still will
report this "vulnerability". In general it would be best to get rid
of jquery-ui completely step by step for TYPO3 v12.

In issue #96335 jquery-ui has been "unpatched" for the TYPO3 core,
thus using the GitHub source URL is not required anymore.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 10

Review log 811

  1. Oliver Hader uploaded patch set 1 01/10/22, 12:14

  2. Oliver Hader marked it work in progress 01/10/22, 12:18

  3. core-ci voted on patch set 1 V -1 01/10/22, 12:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21847

  4. Oliver Hader commented on patch set 1 01/10/22, 12:44

    Gruntfile still misses relevant files to be copies... (see updated core.js)
  5. Oliver Hader uploaded patch set 2 09/19/22, 09:41

  6. Oliver Hader commented on patch set 2 09/19/22, 09:41

    This change is ready for review.
  7. Oliver Hader marked it work in progress 09/19/22, 09:42

  8. core-ci voted on patch set 2 V -1 09/19/22, 09:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31261

  9. Simon Schaufelberger rebased onto patch set 3 09/21/22, 19:54

  10. core-ci voted on patch set 3 V -1 09/21/22, 20:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31393

  11. Oliver Hader abandoned the change 10/03/22, 15:16

    Dead end... → drop jquery-ui