Review main Merged

72944[TASK] Deprecate cObj->getMailTo

Benni Mack CR +2 V +2 Hard +241 −146 updated 01/11/22, 19:22

Commit message

The method cObj->getMailTo() is only used in EmailLinkBuilder
and its functionality is now moved into this class,
as the scope belongs to this class.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1017

  1. Benni Mack uploaded patch set 1 01/10/22, 12:42

  2. core-ci voted on patch set 1 V -1 01/10/22, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21850

  3. Benni Mack uploaded patch set 2 01/10/22, 18:18

  4. core-ci voted on patch set 2 V -1 01/10/22, 18:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21868

  5. Benni Mack uploaded patch set 3 01/10/22, 18:37

  6. core-ci voted on patch set 3 V +1 01/10/22, 18:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21870

  7. Benni Mack updated the commit message in patch set 4 01/10/22, 18:54

  8. core-ci voted on patch set 4 V +1 01/10/22, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21872

  9. Oli Bartsch uploaded patch set 5 01/11/22, 14:16

  10. core-ci voted on patch set 5 V -1 01/11/22, 14:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21910

  11. Oli Bartsch uploaded patch set 6 01/11/22, 15:02

  12. core-ci voted on patch set 6 V -1 01/11/22, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21914

  13. core-ci voted on patch set 6 V +1 01/11/22, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21914

  14. Oli Bartsch voted on patch set 6 V +1 CR +1 01/11/22, 16:14

  15. Stefan Bürk voted on patch set 6 V +1 CR +1 01/11/22, 18:26

  16. Benni Mack voted on patch set 6 V +2 CR +2 01/11/22, 19:22

  17. Benni Mack merged patch set 7 01/11/22, 19:22