Review main Merged Breaking

72945[!!!][TASK] Remove prefixLocalAnchors in HtmlParser

Benni Mack CR +2 V +2 Normal +42 −25 updated 01/13/22, 13:02

Commit message

The option prefixLocalAnchors in HtmlParser was not used
anymore since the removal of its main functionality
in #65934 with TYPO3 v8.0, and is now removed, as it
is a leftover of past functionality before site handling
and proper URL generation.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 913

  1. Benni Mack uploaded patch set 1 01/10/22, 12:57

  2. core-ci voted on patch set 1 V +1 01/10/22, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21852

  3. Oliver Klee updated the commit message in patch set 2 01/10/22, 15:10

  4. core-ci voted on patch set 2 V +1 01/10/22, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21860

  5. Benni Mack updated the commit message in patch set 3 01/10/22, 19:59

  6. core-ci voted on patch set 3 V +1 01/10/22, 20:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21875

  7. Benni Mack uploaded patch set 4 01/12/22, 21:07

  8. core-ci voted on patch set 4 V +1 01/12/22, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21999

  9. Christian Kuhn voted on patch set 4 V +1 CR +1 01/13/22, 09:43

  10. Wouter Wolters voted on patch set 4 V +1 CR +1 01/13/22, 10:01

  11. Georg Ringer voted on patch set 4 V +2 CR +2 01/13/22, 11:12

  12. Georg Ringer merged patch set 5 01/13/22, 11:12

  13. Oliver Hader voted on patch set 5 CR +1 01/13/22, 13:02