Review main Merged

72949[BUGFIX] Enforce functional colors package

Andreas Kienast CR +2 V +2 Easy +4 −6 updated 01/10/22, 20:59

Commit message

The maintainer of the `colors` package decided to rampage and released
a bonkers version, see [1] and [2], causing an implosion of the npm eco
system.
Albeit TYPO3 uses this as a transitive dependency only, we're going
to be safe and enforce this package to version 1.4.0, the current known
to-be-stable version.

[1] https://github.com/Marak/colors.js/issues/285
[2] https://www.bleepingcomputer.com/news/security/dev-corrupts-npm-libs-colors-and-faker-breaking-thousands-of-apps/

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1113

  1. Andreas Kienast uploaded patch set 1 01/10/22, 16:56

  2. Mathias Brodala voted on patch set 1 CR +1 01/10/22, 17:00

  3. core-ci voted on patch set 1 V +1 01/10/22, 17:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21863

  4. Oliver Hader voted on patch set 1 CR +1 01/10/22, 17:38

  5. Oliver Klee voted on patch set 1 CR +1 01/10/22, 17:50

  6. Benjamin Franzke commented on patch set 1 CR -1 01/10/22, 18:02

    package.json:119

    yarn install … warning Resolution field "colors@1.4.0" is incompatible with requested version "colors@~1.1.2"

    yarn.lock:2033

    Hm, so the package that requires ~1.1.2 of "colors" now receives 1.4.0. Affected is only grunt-legacy-log and since grunt still works it is probably ok.
  7. Benjamin Franzke uploaded patch set 2 01/10/22, 18:07

  8. Benjamin Franzke commented on patch set 2 01/10/22, 18:07

    package.json:119 Reply

    Fixed.
  9. core-ci voted on patch set 2 V +1 01/10/22, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21867

  10. Oliver Klee voted on patch set 2 CR +1 01/10/22, 18:35

  11. Wouter Wolters voted on patch set 2 CR +1 01/10/22, 19:15

  12. Andreas Kienast voted on patch set 2 V +2 CR +2 01/10/22, 20:59

  13. Andreas Kienast merged patch set 3 01/10/22, 20:59