Review 11.5 Merged

72951[BUGFIX] Enforce functional colors package

Andreas Kienast CR +2 V +2 Easy +4 −6 updated 01/10/22, 21:22

Commit message

The maintainer of the `colors` package decided to rampage and released
a bonkers version, see [1] and [2], causing an implosion of the npm eco
system.
Albeit TYPO3 uses this as a transitive dependency only, we're going
to be safe and enforce this package to version 1.4.0, the current known
to-be-stable version.

[1] https://github.com/Marak/colors.js/issues/285
[2] https://www.bleepingcomputer.com/news/security/dev-corrupts-npm-libs-colors-and-faker-breaking-thousands-of-apps/

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Andreas Kienast uploaded patch set 1 01/10/22, 21:05

  2. core-ci voted on patch set 1 V +1 01/10/22, 21:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21879

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 01/10/22, 21:22

  4. Andreas Kienast merged patch set 2 01/10/22, 21:22