Review main Merged

72952[BUGFIX] Correctly apply config.absRefPrefix to _assets resources

Oliver Hader CR +2 V +2 Easy +2 −0 updated 01/10/22, 22:24

Commit message

When using a composer-based installation, public frontend assets
such as JavaScript of stylesheet files are exposed in a dedicated
`_assets/` folder. In those scenarios TypoScript settings for
`config.absRefPrefix` need to be applied as well.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Simon Gilli +1
    • Helmut Hummel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Simon Gilli +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Oliver Hader uploaded patch set 1 01/10/22, 21:29

  2. Benni Mack voted on patch set 1 CR +1 01/10/22, 21:30

  3. Helmut Hummel voted on patch set 1 CR +1 01/10/22, 21:42

  4. core-ci voted on patch set 1 V +1 01/10/22, 21:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21881

  5. Simon Gilli voted on patch set 1 V +1 CR +1 01/10/22, 22:14

  6. Oliver Hader voted on patch set 1 V +2 CR +2 01/10/22, 22:24

  7. Oliver Hader merged patch set 2 01/10/22, 22:24