Review main Merged Breaking

72953[!!!][TASK] Remove config.disablePageExternalUrl option

Benni Mack CR +2 V +2 Normal +64 −11 updated 01/13/22, 20:41

Commit message

The option "config.disablePageExternalUrl", which allowed
to bypass the External URL linking (used for special
jumpurl-like functionality and sys_stat) is removed in
favor of custom implementations for middlewares.

In addition, if a page with external URL cannot be
resolved properly, an error response is now triggered (pageNotFound)

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1015

  1. Benni Mack uploaded patch set 1 01/10/22, 21:38

  2. core-ci voted on patch set 1 V +1 01/10/22, 21:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21882

  3. Oliver Klee updated the commit message in patch set 2 01/11/22, 11:06

  4. core-ci voted on patch set 2 V +1 01/11/22, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21897

  5. Benni Mack updated the commit message in patch set 3 01/12/22, 15:49

  6. core-ci voted on patch set 3 V +1 01/12/22, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21981

  7. Benni Mack uploaded patch set 4 01/12/22, 19:38

  8. core-ci voted on patch set 4 V +1 01/12/22, 19:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21995

  9. Georg Ringer voted on patch set 4 V +1 CR +1 01/13/22, 07:20

  10. Wouter Wolters commented on patch set 4 CR -1 01/13/22, 10:02

    typo3/sysext/t3editor/Resources/Private/tsref.xml typo3/sysext/t3editor/Resources/Public/JavaScript/Mode/typoscript/typoscript.js Both files contain a reference to disablePageExternalUrl
  11. Benni Mack uploaded patch set 5 01/13/22, 20:14

  12. core-ci voted on patch set 5 V +1 01/13/22, 20:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22039

  13. Stefan Bürk voted on patch set 5 V +1 CR +1 01/13/22, 20:39

  14. Christian Kuhn voted on patch set 5 V +2 CR +2 01/13/22, 20:41

  15. Christian Kuhn merged patch set 6 01/13/22, 20:41