Review main Merged Breaking

72955[!!!][FEATURE] Add new Event for filtering HMENU items

Benni Mack CR +2 V +2 Hard +270 −33 updated 01/13/22, 07:37

Commit message

This change introduces a new PSR-14 event for manipulating
menu items in a menu.

The hook
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/tslib/class.tslib_menu.php']['filterMenuPages']
is removed, and AbstractMenuFilterPagesHookInterface deprecated.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1121

  1. Benni Mack uploaded patch set 1 01/10/22, 21:51

  2. Benni Mack uploaded patch set 2 01/10/22, 21:59

  3. core-ci voted on patch set 1 V -1 01/10/22, 22:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21884

  4. core-ci voted on patch set 2 V -1 01/10/22, 22:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21885

  5. core-ci commented on patch set 2 01/10/22, 22:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21885

  6. Benni Mack uploaded patch set 3 01/11/22, 10:05

  7. core-ci voted on patch set 3 V -1 01/11/22, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21893

  8. Benni Mack uploaded patch set 4 01/11/22, 11:06

  9. core-ci voted on patch set 4 V -1 01/11/22, 11:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21896

  10. Benni Mack updated the commit message in patch set 5 01/11/22, 11:37

  11. core-ci voted on patch set 5 V -1 01/11/22, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21900

  12. Benni Mack uploaded patch set 6 01/11/22, 21:17

  13. core-ci voted on patch set 6 V +1 01/11/22, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21941

  14. Benni Mack uploaded patch set 7 01/12/22, 10:33

  15. core-ci voted on patch set 7 V -1 01/12/22, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21955

  16. core-ci voted on patch set 7 V +1 01/12/22, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21955

  17. Oli Bartsch uploaded patch set 8 01/12/22, 17:14

  18. Oli Bartsch voted on patch set 8 V +1 CR +1 01/12/22, 17:19

  19. core-ci voted on patch set 8 V +1 01/12/22, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21989

  20. Georg Ringer voted on patch set 8 V +2 CR +2 01/13/22, 07:37

  21. Georg Ringer merged patch set 9 01/13/22, 07:37