Review main Merged

72960[FEATURE] Add aliases to Backend Routes and Modules

Benni Mack CR +2 V +2 Hard +607 −34 updated 07/14/22, 13:32

Commit message

Symfony 5.4 ships with a new feature to add "aliases"
to routes. TYPO3 can now replace legacy and complicated
names for routes or modules with new ones while keeping
backwards-compatibility with old links / references.

See https://symfony.com/blog/new-in-symfony-5-4-route-aliasing
for more details.

Module registration now allows to define "aliases" (array),
same for route registration.

As an example, complicated module name such as "web_WorkspacesWorkspaces"
is renamed to "workspaces_admin" which reflects the current possibilities
for module identifiers much better.

An upgrade wizard migrates the current backend user
and backend group permissions ("userMods" and "groupMods")
to the new logic.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 30

Show 10 more files

Review log 2744

Show 1119 earlier messages
  1. Benni Mack uploaded patch set 1 01/11/22, 10:10

  2. core-ci voted on patch set 1 V -1 01/11/22, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21894

  3. Benni Mack uploaded patch set 2 01/11/22, 20:13

  4. core-ci voted on patch set 2 V -1 01/11/22, 20:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21933

  5. Benni Mack uploaded patch set 3 01/11/22, 20:39

  6. core-ci voted on patch set 3 V -1 01/11/22, 20:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21936

  7. Benni Mack uploaded patch set 4 01/11/22, 21:00

  8. core-ci voted on patch set 4 V -1 01/11/22, 21:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21939

  9. Benni Mack uploaded patch set 5 01/11/22, 21:14

  10. core-ci voted on patch set 5 V -1 01/11/22, 21:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21940

  11. Benni Mack uploaded patch set 6 01/11/22, 21:54

  12. core-ci voted on patch set 6 V -1 01/11/22, 22:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21944

  13. Jochen Roth uploaded patch set 7 01/12/22, 14:16

  14. Jochen Roth commented on patch set 7 01/12/22, 14:19

    To get the ac tests running on a Apple Arm (M1) use the following image in the docker-compose.yml "seleniarm/standalone-chromium:latest"
  15. Jochen Roth commented on patch set 7 01/12/22, 14:21

    Reply

    ... already talked to lolli, we tend to wait for selenium to fix this. But for now the hack works.
  16. core-ci voted on patch set 7 V +1 01/12/22, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21975

  17. Benni Mack uploaded patch set 8 03/09/22, 22:02

  18. core-ci voted on patch set 8 V +1 03/09/22, 22:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24777

  19. Benni Mack uploaded patch set 9 03/11/22, 18:55

  1. core-ci voted on patch set 9 V +1 03/11/22, 19:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24839

  2. Benni Mack uploaded patch set 10 07/13/22, 09:26

  3. core-ci voted on patch set 10 V +1 07/13/22, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29043

  4. Benni Mack uploaded patch set 11 07/13/22, 10:03

  5. core-ci voted on patch set 11 V -1 07/13/22, 10:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29049

  6. Benni Mack uploaded patch set 12 07/13/22, 11:06

  7. core-ci voted on patch set 12 V +1 07/13/22, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29056

  8. Oli Bartsch commented on patch set 12 07/13/22, 16:50

    ExtbaseModule.php:61

    This should be removed again.

    ModuleFactory.php:77

    Shouldn't this be moved to the registry?

    ModuleRegistry.php:291

    So the last extension defining an alias wins if multiple extensions define the same alias? We might want to throw an exception instead?

    ModuleRegistry.php:296

    I think this should be internal
  9. Benni Mack uploaded patch set 13 07/13/22, 17:40

  10. core-ci voted on patch set 13 V +1 07/13/22, 17:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29081

  11. Benni Mack commented on patch set 13 07/13/22, 19:24

    ExtbaseModule.php:61 Reply

    Done

    ModuleFactory.php:77 Reply

    Done

    ModuleRegistry.php:291 Reply

    Done

    ModuleRegistry.php:296 Reply

    Done
  12. Benni Mack rebased onto patch set 14 07/13/22, 19:33

  13. Oli Bartsch uploaded patch set 15 07/13/22, 19:34

  14. core-ci voted on patch set 14 V +1 07/13/22, 19:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29094

  15. core-ci voted on patch set 15 V +1 07/13/22, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29095

  16. Oli Bartsch commented on patch set 15 CR -1 07/14/22, 08:09

    On it
  17. Oli Bartsch uploaded patch set 16 07/14/22, 11:08

  18. core-ci voted on patch set 16 V +1 07/14/22, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29136

  19. Oli Bartsch voted on patch set 16 V +1 CR +1 07/14/22, 11:24

  20. Andreas Kienast uploaded patch set 17 07/14/22, 12:39

  21. Andreas Kienast voted on patch set 17 V +1 CR +1 07/14/22, 12:39

  22. Oli Bartsch voted on patch set 17 V +1 CR +1 07/14/22, 12:40

  23. core-ci voted on patch set 17 V +1 07/14/22, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29145

  24. Benni Mack voted on patch set 17 V +2 CR +2 07/14/22, 13:32

  25. Benni Mack merged patch set 18 07/14/22, 13:32