72960[FEATURE] Add aliases to Backend Routes and Modules
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 30
- Build/Sources/TypeScript/workspaces/toolbar/workspaces-menu.ts+5 −7
- Build/Sources/TypeScript/workspaces/backend.ts+3 −3
- typo3/sysext/backend/Classes/Module/BaseModule.php+9 −0
- typo3/sysext/backend/Classes/Module/MenuModule.php+5 −0
- typo3/sysext/backend/Classes/Module/ModuleFactory.php2+31 −0
- typo3/sysext/backend/Classes/Module/ModuleInterface.php+5 −0
- typo3/sysext/backend/Classes/Module/ModuleRegistry.php4+29 −2
- typo3/sysext/backend/Classes/Routing/Router.php+6 −2
- typo3/sysext/backend/Classes/ServiceProvider.php+6 −4
- typo3/sysext/backend/Tests/Functional/Routing/RouterTest.php+15 −0
- typo3/sysext/backend/Tests/Functional/Routing/UriBuilderTest.phpnew+40 −0
- typo3/sysext/backend/Tests/Unit/Module/ModuleFactoryTest.phpnew+132 −0
- typo3/sysext/backend/Tests/Unit/Module/ModuleRegistryTest.php+20 −3
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-96515-AliasesForBackendRoutesAndBackendModules.rstnew+61 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-96733-NewBackendModuleRegistrationAPI.rst+10 −0
- typo3/sysext/install/Classes/Updates/BackendModulePermissionMigration.phpnew+123 −0
- typo3/sysext/install/Classes/Updates/ShortcutRecordsMigration.php+6 −2
- typo3/sysext/install/Tests/Functional/Updates/Fixtures/BackendModulePermissionMigrationAfter.csvnew+16 −0
- typo3/sysext/install/Tests/Functional/Updates/Fixtures/BackendModulePermissionMigrationBefore.csvnew+16 −0
- typo3/sysext/install/Tests/Functional/Updates/BackendModulePermissionMigrationTest.phpnew+49 −0
Show 10 more files
- typo3/sysext/install/ext_localconf.php+2 −0
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/BackendModuleProvider.php+1 −0
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/BackendRoutesProvider.php+6 −1
- typo3/sysext/workspaces/Classes/Backend/ToolbarItems/WorkspaceSelectorToolbarItem.php+1 −1
- typo3/sysext/workspaces/Classes/Controller/ReviewController.php+3 −3
- typo3/sysext/workspaces/Configuration/Backend/Modules.php+3 −2
- typo3/sysext/workspaces/Resources/Private/Templates/Review/Index.html+1 −1
- typo3/sysext/workspaces/Resources/Private/Templates/ToolbarItems/DropDown.html+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/toolbar/workspaces-menu.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js+1 −1
Review log 2744
Show 1119 earlier messages
-
Benni Mack uploaded patch set 1 01/11/22, 10:10
-
core-ci voted on patch set 1 V -1 01/11/22, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21894
-
Benni Mack uploaded patch set 2 01/11/22, 20:13
-
core-ci voted on patch set 2 V -1 01/11/22, 20:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21933
-
Benni Mack uploaded patch set 3 01/11/22, 20:39
-
core-ci voted on patch set 3 V -1 01/11/22, 20:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21936
-
Benni Mack uploaded patch set 4 01/11/22, 21:00
-
core-ci voted on patch set 4 V -1 01/11/22, 21:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21939
-
Benni Mack uploaded patch set 5 01/11/22, 21:14
-
core-ci voted on patch set 5 V -1 01/11/22, 21:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21940
-
Benni Mack uploaded patch set 6 01/11/22, 21:54
-
core-ci voted on patch set 6 V -1 01/11/22, 22:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21944
-
Jochen Roth uploaded patch set 7 01/12/22, 14:16
-
Jochen Roth commented on patch set 7 01/12/22, 14:19
To get the ac tests running on a Apple Arm (M1) use the following image in the docker-compose.yml "seleniarm/standalone-chromium:latest" -
Jochen Roth commented on patch set 7 01/12/22, 14:21
Reply
... already talked to lolli, we tend to wait for selenium to fix this. But for now the hack works. -
core-ci voted on patch set 7 V +1 01/12/22, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21975
-
Benni Mack uploaded patch set 8 03/09/22, 22:02
-
core-ci voted on patch set 8 V +1 03/09/22, 22:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24777
-
Benni Mack uploaded patch set 9 03/11/22, 18:55
-
core-ci voted on patch set 9 V +1 03/11/22, 19:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24839
-
Benni Mack uploaded patch set 10 07/13/22, 09:26
-
core-ci voted on patch set 10 V +1 07/13/22, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29043
-
Benni Mack uploaded patch set 11 07/13/22, 10:03
-
core-ci voted on patch set 11 V -1 07/13/22, 10:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29049
-
Benni Mack uploaded patch set 12 07/13/22, 11:06
-
core-ci voted on patch set 12 V +1 07/13/22, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29056
-
Oli Bartsch commented on patch set 12 07/13/22, 16:50
ExtbaseModule.php:61This should be removed again.ModuleFactory.php:77Shouldn't this be moved to the registry?ModuleRegistry.php:291So the last extension defining an alias wins if multiple extensions define the same alias? We might want to throw an exception instead?ModuleRegistry.php:296I think this should be internal -
Benni Mack uploaded patch set 13 07/13/22, 17:40
-
core-ci voted on patch set 13 V +1 07/13/22, 17:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29081
-
Benni Mack commented on patch set 13 07/13/22, 19:24
ExtbaseModule.php:61ReplyDoneModuleFactory.php:77ReplyDoneModuleRegistry.php:291ReplyDoneModuleRegistry.php:296ReplyDone -
Benni Mack rebased onto patch set 14 07/13/22, 19:33
-
Oli Bartsch uploaded patch set 15 07/13/22, 19:34
-
core-ci voted on patch set 14 V +1 07/13/22, 19:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29094
-
core-ci voted on patch set 15 V +1 07/13/22, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29095
-
Oli Bartsch commented on patch set 15 CR -1 07/14/22, 08:09
On it -
Oli Bartsch uploaded patch set 16 07/14/22, 11:08
-
core-ci voted on patch set 16 V +1 07/14/22, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29136
-
Oli Bartsch voted on patch set 16 V +1 CR +1 07/14/22, 11:24
-
Andreas Kienast uploaded patch set 17 07/14/22, 12:39
-
Andreas Kienast voted on patch set 17 V +1 CR +1 07/14/22, 12:39
-
Oli Bartsch voted on patch set 17 V +1 CR +1 07/14/22, 12:40
-
core-ci voted on patch set 17 V +1 07/14/22, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29145
-
Benni Mack voted on patch set 17 V +2 CR +2 07/14/22, 13:32
-
Benni Mack merged patch set 18 07/14/22, 13:32