Review main Merged

72962[BUGFIX] Avoid bogus title in new record controller

Christian Kuhn CR +2 V +2 Easy +7 −5 updated 01/11/22, 16:52

Commit message

NewRecordController (+ icon in doc header of list
module) renders "Create a new page" on top. This
is not a link and looks misplaced.

It is a 'section header' for optional content that can
be enabled via pageTS.

mod.wizards.newRecord.pages.show.pageSelectPosition = 1
mod.wizards.newRecord.pages.show.pageInside = 1
mod.wizards.newRecord.pages.show.pageAfter = 1

When at least one of these are enabled, the header
makes sense, but should be avoided otherwise.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 69

  1. Christian Kuhn uploaded patch set 1 01/11/22, 11:32

  2. core-ci voted on patch set 1 V -1 01/11/22, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21899

  3. core-ci voted on patch set 1 V +1 01/11/22, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21899

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 01/11/22, 16:25

  5. Christian Kuhn updated the commit message in patch set 2 01/11/22, 16:30

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 01/11/22, 16:32

  7. core-ci voted on patch set 2 V +1 01/11/22, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21917

  8. Andreas Kienast voted on patch set 2 V +2 CR +2 01/11/22, 16:52

  9. Andreas Kienast merged patch set 3 01/11/22, 16:52