Review main Merged

72963[BUGFIX] Avoid PHP 8 warnings in ext:scheduler

Christian Kuhn CR +2 V +2 Easy +3 −3 updated 01/11/22, 16:16

Commit message

Scheduler backend module -> Add button -> add some valid
information that makes the form save correctly -> "Save
and new" from docheader save drop down -> boom.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Christian Kuhn uploaded patch set 1 01/11/22, 11:48

  2. core-ci voted on patch set 1 V +1 01/11/22, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21901

  3. Oliver Hader voted on patch set 1 CR +1 01/11/22, 13:06

  4. Oliver Hader voted on patch set 1 V +1 01/11/22, 13:06

  5. Oliver Klee commented on patch set 1 01/11/22, 13:09

    SchedulerModuleController.php:548

    I propose we put the UID in a local variable which we then can use in the other places (in order to avoid having this operator multiple times).
  6. Christian Kuhn commented on patch set 1 01/11/22, 13:54

    SchedulerModuleController.php:548 Reply

    Na. I have a huge scheduler refactoring in a WIP patch where $this->submittedData will vanish entirely. This one here is a pre-patch. Let's please keep this as small as possible to give me the smallest amount of rebasing headaches ;)
  7. Oliver Klee voted on patch set 1 CR +1 01/11/22, 15:39

  8. Oli Bartsch voted on patch set 1 V +2 CR +2 01/11/22, 16:16

  9. Oli Bartsch merged patch set 2 01/11/22, 16:16