Review main Merged

72965[TASK] ClickEnlargeViewhelper PHP 8.0/8.1 compatibility

TYPO3com CR +2 V +2 Easy +1 −1 updated 01/12/22, 10:33

Commit message

Fixes 'Undefined array key "crop"' exception in PHP 8.0/8.1
when rendering an image with enabled clickenlarge and defined
cropVariants.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 913

  1. TYPO3com uploaded patch set 1 01/11/22, 12:13

  2. core-ci voted on patch set 1 V +1 01/11/22, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21905

  3. Benni Mack updated the commit message in patch set 2 01/11/22, 12:55

  4. core-ci voted on patch set 2 V +1 01/11/22, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21907

  5. Oliver Klee voted on patch set 2 CR +1 01/11/22, 13:09

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 01/11/22, 16:23

  7. Stefan Bürk updated the commit message in patch set 3 01/11/22, 18:22

  8. Stefan Bürk voted on patch set 3 V +1 CR +1 01/11/22, 18:23

  9. Oliver Klee voted on patch set 3 CR +1 01/11/22, 18:29

  10. core-ci voted on patch set 3 V +1 01/11/22, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21928

  11. Georg Ringer voted on patch set 3 V +1 CR +1 01/12/22, 09:55

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 01/12/22, 10:33

  13. Christian Kuhn merged patch set 4 01/12/22, 10:33