72966[TASK] Simplify Templating Bootstrap in BE Controllers
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 14
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+4 −4
- typo3/sysext/backend/Classes/ViewHelpers/Link/EditRecordViewHelper.php+7 −2
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLinkViewHelper.php+9 −2
- typo3/sysext/fluid/Classes/View/BackendTemplateView.php3new+28 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageRendererViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/EmailViewHelper.php+6 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/EmailViewHelperTest.php+2 −6
- typo3/sysext/sys_note/Classes/Controller/NoteController.php+15 −19
- typo3/sysext/sys_note/Classes/Hook/InfoModuleHook.php2+9 −6
- typo3/sysext/sys_note/Classes/Hook/PageHook.php+15 −14
- typo3/sysext/sys_note/Classes/Provider/RecordListProvider.php+8 −5
- typo3/sysext/sys_note/Resources/Private/Layouts/Default.htmldeleted+0 −1
- typo3/sysext/sys_note/Resources/Private/Templates/Note/List.htmldeleted+0 −58
- typo3/sysext/sys_note/Resources/Private/Templates/List.htmlnew+66 −0
Review log 1624
-
Christian Kuhn uploaded patch set 1 01/11/22, 12:37
-
core-ci voted on patch set 1 V -1 01/11/22, 12:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21906
-
Christian Kuhn uploaded patch set 2 01/11/22, 15:05
-
core-ci voted on patch set 2 V +1 01/11/22, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21915
-
Christian Kuhn uploaded patch set 3 01/11/22, 17:24
-
core-ci voted on patch set 3 V +1 01/11/22, 17:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21921
-
Christian Kuhn uploaded patch set 4 01/11/22, 17:56
-
Christian Kuhn uploaded patch set 5 01/11/22, 17:59
-
Christian Kuhn updated the commit message in patch set 6 01/11/22, 18:04
-
Christian Kuhn updated the commit message in patch set 7 01/11/22, 18:06
-
core-ci voted on patch set 4 V -1 01/11/22, 18:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21923
-
core-ci voted on patch set 5 V -1 01/11/22, 18:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21924
-
core-ci voted on patch set 6 V +1 01/11/22, 18:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21926
-
core-ci voted on patch set 7 V +1 01/11/22, 18:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21927
-
Benni Mack updated the commit message in patch set 8 01/11/22, 20:47
-
Benni Mack commented on patch set 8 CR +1 01/11/22, 20:49
-
core-ci voted on patch set 8 V +1 01/11/22, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21938
-
Benni Mack commented on patch set 8 V +1 01/11/22, 21:09
InfoModuleHook.php:39ReplyDone -
Benjamin Franzke commented on patch set 8 01/11/22, 21:24
BackendTemplateView.php:26I'd love if we'd rather use https://github.com/TYPO3/Fluid/blob/master/src/View/TemplateView.php instead of generating a new TemplateView class. The upcoming factory can then easily create a vanilla fluid template view. I do not see the reason for a separate class in here. -
Benni Mack commented on patch set 8 01/11/22, 21:30
BackendTemplateView.php:26ReplyThe idea is to use this class for now and migrate the TYPO3 Backend completely to not use StandaloneView anymore. I plan to then integrate https://review.typo3.org/c/Packages/TYPO3.CMS/+/72794 and - at this point, we should use DI properly, and remove the class again, OK? -
Benjamin Franzke commented on patch set 8 01/12/22, 10:23
BackendTemplateView.php:26ReplyOK, yea. -
Oli Bartsch voted on patch set 8 V +1 CR +1 01/12/22, 11:20
-
Christian Kuhn voted on patch set 8 V +2 CR +2 01/12/22, 11:21
-
Christian Kuhn merged patch set 9 01/12/22, 11:21
InfoModuleHook.php:39