Review main Merged

72971[BUGFIX] Calculate action menu generation earlier in PageLayoutController

Oli Bartsch CR +2 V +2 Easy +4 −4 updated 01/11/22, 20:42

Commit message

With #95387 the menu generation of the page module
was moved to the end of the request handling method.

However, the `makeActionMenu()` method does currently
not only create the menu but does also make some sanity
check, whether the currently selected `function` is actually
available.

If not, the `function` is reset to the default ("columns mode").
This e.g. happens when in languages mode and then switching
to another domain / another site, which is single language only.
This then led to the user being unable to work in "columns mode",
since no action menu is generated for such sites.

This is now fixed by executing the mentioned method before the
content gets generated.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 01/11/22, 18:31

  2. core-ci voted on patch set 1 V +1 01/11/22, 18:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21930

  3. Benni Mack voted on patch set 1 V +1 CR +1 01/11/22, 19:21

  4. Jochen Roth voted on patch set 1 V +1 CR +1 01/11/22, 20:36

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 01/11/22, 20:41

  6. Oli Bartsch merged patch set 2 01/11/22, 20:42