Review 11.5 Merged

72976[BUGFIX] Do not hsc twice the title in indexed search

Benni Mack CR +2 V +2 Easy +4 −4 updated 01/11/22, 20:42

Commit message

The path gets htmlspecialchared with linkPageATagWrap()
and before that it gets treated within getPathFromPageId()
already.

This change removes the double encoding.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Benni Mack commented on patch set 1 01/11/22, 20:22

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/indexed_search/Classes/Controller/SearchController.php
  2. Benni Mack commented on patch set 2 01/11/22, 20:22

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 01/11/22, 20:22

  4. core-ci voted on patch set 1 V -1 01/11/22, 20:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21934

  5. core-ci voted on patch set 2 V +1 01/11/22, 20:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21935

  6. Benni Mack voted on patch set 2 V +2 CR +2 01/11/22, 20:42

  7. Benni Mack merged patch set 3 01/11/22, 20:42