Review main Merged

72992[BUGFIX] Use optgroup in SelectMultipleSideBySideElement

Oli Bartsch CR +2 V +2 Normal +98 −22 updated 01/12/22, 10:24

Commit message

Instead of using multiple "fake" <option> elements with
the same value `--div--`, the SelectMultipleSideBySideElement
does now use proper HTML <optgroup> elements for grouping
of the available options. This is in line with other
select elements, e.g. the SelectSingleElement.

Besides the improved HTML markup, this also improves
the UI, since the <optgroup> element is non-selectable.
It is also no longer considered by the filter, which
previously led to confusion, especially when filtering
and having the "dividers" as only options left.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1317

  1. Oli Bartsch uploaded patch set 1 01/11/22, 21:34

  2. core-ci voted on patch set 1 V +1 01/11/22, 21:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21942

  3. Oli Bartsch uploaded patch set 2 01/12/22, 00:07

  4. core-ci voted on patch set 2 V +1 01/12/22, 00:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21945

  5. Oli Bartsch uploaded patch set 3 01/12/22, 00:23

  6. core-ci voted on patch set 3 V +1 01/12/22, 00:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21946

  7. Jochen Roth voted on patch set 3 V +1 CR +1 01/12/22, 09:04

  8. Benni Mack voted on patch set 3 V +1 CR +1 01/12/22, 09:09

  9. Oli Bartsch commented on patch set 3 CR -1 01/12/22, 09:35

    Will update

    SelectBoxFilter.ts:69

    toggle
  10. Oli Bartsch uploaded patch set 4 01/12/22, 09:42

  11. Oli Bartsch commented on patch set 4 01/12/22, 09:43

    SelectBoxFilter.ts:69 Reply

    Done
  12. core-ci voted on patch set 4 V +1 01/12/22, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21951

  13. Benni Mack voted on patch set 4 V +1 CR +1 01/12/22, 10:09

  14. Jochen Roth voted on patch set 4 V +1 CR +1 01/12/22, 10:10

  15. Christian Kuhn voted on patch set 4 V +1 CR +1 01/12/22, 10:10

  16. Oli Bartsch voted on patch set 4 V +2 CR +2 01/12/22, 10:24

  17. Oli Bartsch merged patch set 5 01/12/22, 10:24