72992[BUGFIX] Use optgroup in SelectMultipleSideBySideElement
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 8
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/Extra/SelectBoxFilter.ts2+15 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/AbstractSortableSelectItems.ts+1 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine.ts+27 −5
- Build/types/TYPO3/index.d.ts+3 −2
- typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php+49 −12
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/Extra/SelectBoxFilter.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/AbstractSortableSelectItems.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine.js+1 −1
Review log 1317
-
Oli Bartsch uploaded patch set 1 01/11/22, 21:34
-
core-ci voted on patch set 1 V +1 01/11/22, 21:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21942
-
Oli Bartsch uploaded patch set 2 01/12/22, 00:07
-
core-ci voted on patch set 2 V +1 01/12/22, 00:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21945
-
Oli Bartsch uploaded patch set 3 01/12/22, 00:23
-
core-ci voted on patch set 3 V +1 01/12/22, 00:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21946
-
Jochen Roth voted on patch set 3 V +1 CR +1 01/12/22, 09:04
-
Benni Mack voted on patch set 3 V +1 CR +1 01/12/22, 09:09
-
Oli Bartsch uploaded patch set 4 01/12/22, 09:42
-
Oli Bartsch commented on patch set 4 01/12/22, 09:43
SelectBoxFilter.ts:69ReplyDone -
core-ci voted on patch set 4 V +1 01/12/22, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21951
-
Benni Mack voted on patch set 4 V +1 CR +1 01/12/22, 10:09
-
Jochen Roth voted on patch set 4 V +1 CR +1 01/12/22, 10:10
-
Christian Kuhn voted on patch set 4 V +1 CR +1 01/12/22, 10:10
-
Oli Bartsch voted on patch set 4 V +2 CR +2 01/12/22, 10:24
-
Oli Bartsch merged patch set 5 01/12/22, 10:24