Review 11.5 Merged

72993[BUGFIX] Use optgroup in SelectMultipleSideBySideElement

Oli Bartsch CR +2 V +2 Normal +97 −21 updated 01/12/22, 11:22

Commit message

Instead of using multiple "fake" <option> elements with
the same value `--div--`, the SelectMultipleSideBySideElement
does now use proper HTML <optgroup> elements for grouping
of the available options. This is in line with other
select elements, e.g. the SelectSingleElement.

Besides the improved HTML markup, this also improves
the UI, since the <optgroup> element is non-selectable.
It is also no longer considered by the filter, which
previously led to confusion, especially when filtering
and having the "dividers" as only options left.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 34

  1. Oli Bartsch uploaded patch set 1 01/12/22, 10:33

  2. core-ci voted on patch set 1 V +1 01/12/22, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21956

  3. Oli Bartsch voted on patch set 1 V +2 CR +2 01/12/22, 11:22

  4. Oli Bartsch merged patch set 2 01/12/22, 11:22