72996[TASK] Modernize backend toolbar code
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 37
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Toolbar/LiveSearch.tsrenamed+5 −5
- typo3/sysext/backend/Classes/Backend/ToolbarItems/ClearCacheToolbarItem.php+29 −69
- typo3/sysext/backend/Classes/Backend/ToolbarItems/HelpToolbarItem.php+26 −48
- typo3/sysext/backend/Classes/Backend/ToolbarItems/LiveSearchToolbarItem.php+26 −66
- typo3/sysext/backend/Classes/Backend/ToolbarItems/ShortcutToolbarItem.php+29 −88
- typo3/sysext/backend/Classes/Backend/ToolbarItems/SystemInformationToolbarItem.php+75 −173
- typo3/sysext/backend/Classes/Backend/ToolbarItems/UserToolbarItem.php+33 −63
- typo3/sysext/backend/Classes/Controller/ShortcutController.php+39 −99
- typo3/sysext/backend/Classes/Controller/SystemInformationController.php+11 −6
- typo3/sysext/backend/Configuration/Services.yaml+15 −0
- typo3/sysext/backend/Resources/Private/Partials/ShortcutToolbarItem/Shortcut.htmldeleted+0 −28
- typo3/sysext/backend/Resources/Private/Templates/ShortcutToolbarItem/DropDown.htmldeleted+0 −32
- typo3/sysext/backend/Resources/Private/Templates/ShortcutToolbarItem/Item.htmldeleted+0 −6
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/ClearCacheToolbarItem.html+6 −1
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/ClearCacheToolbarItemSingle.html+6 −1
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/HelpToolbarItem.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/HelpToolbarItemDropDown.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/LiveSearchToolbarItem.html+15 −4
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/ShortcutToolbarItemDropDown.htmlnew+59 −0
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/ShortcutToolbarItemEditForm.htmlrenamed+0 −0
Show 17 more files
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/ShortcutToolbarItemItem.htmlnew+20 −0
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/SystemInformationDropDown.html+7 −5
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/SystemInformationToolbarItem.html+6 −1
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/UserToolbarItem.html+5 −4
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/UserToolbarItemDropDown.html+18 −5
- typo3/sysext/backend/Resources/Public/JavaScript/Toolbar/LiveSearch.jsrenamed+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/ShortcutControllerTest.php+10 −27
- typo3/sysext/belog/Classes/Controller/SystemInformationController.php+7 −2
- typo3/sysext/core/Resources/Private/Language/locallang_misc.xlf+1 −4
- typo3/sysext/opendocs/Classes/Backend/ToolbarItems/OpendocsToolbarItem.php+31 −75
- typo3/sysext/opendocs/Classes/Controller/OpenDocumentController.php+12 −28
- typo3/sysext/opendocs/Configuration/Services.yaml3+6 −0
- typo3/sysext/opendocs/Resources/Private/Templates/ToolbarItems/DropDown.html+9 −6
- typo3/sysext/opendocs/Resources/Private/Templates/ToolbarItems/ToolbarItem.html+2 −2
- typo3/sysext/workspaces/Classes/Backend/ToolbarItems/WorkspaceSelectorToolbarItem.php+34 −85
- typo3/sysext/workspaces/Resources/Private/Templates/ToolbarItems/DropDown.html+0 −2
- typo3/sysext/workspaces/Resources/Private/Templates/ToolbarItems/ToolbarItem.html+9 −1
Review log 2542
Show 917 earlier messages
-
Christian Kuhn uploaded patch set 1 01/12/22, 11:47
-
Christian Kuhn uploaded patch set 2 01/12/22, 11:52
-
core-ci voted on patch set 1 V -1 01/12/22, 12:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21963
-
core-ci voted on patch set 2 V -1 01/12/22, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21964
-
Christian Kuhn uploaded patch set 3 01/12/22, 12:37
-
core-ci voted on patch set 3 V -1 01/12/22, 12:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21968
-
Christian Kuhn uploaded patch set 4 01/12/22, 13:21
-
core-ci voted on patch set 4 V -1 01/12/22, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21969
-
Christian Kuhn uploaded patch set 5 01/12/22, 15:47
-
core-ci voted on patch set 5 V -1 01/12/22, 15:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21980
-
Christian Kuhn uploaded patch set 6 01/12/22, 15:53
-
Christian Kuhn uploaded patch set 7 01/12/22, 15:58
-
core-ci voted on patch set 7 V -1 01/12/22, 16:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21983
-
core-ci voted on patch set 6 V -1 01/12/22, 16:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21982
-
Christian Kuhn uploaded patch set 8 01/12/22, 17:32
-
Christian Kuhn uploaded patch set 9 01/12/22, 17:33
-
core-ci voted on patch set 8 V -1 01/12/22, 17:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21990
-
Christian Kuhn uploaded patch set 10 01/12/22, 17:48
-
core-ci voted on patch set 9 V +1 01/12/22, 17:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21991
-
core-ci voted on patch set 10 V +1 01/12/22, 18:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21992
-
Christian Kuhn uploaded patch set 11 01/12/22, 18:31
-
Christian Kuhn uploaded patch set 12 01/12/22, 18:33
-
core-ci voted on patch set 11 V -1 01/12/22, 18:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21993
-
core-ci voted on patch set 12 V +1 01/12/22, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21994
-
Christian Kuhn uploaded patch set 13 01/13/22, 09:53
-
core-ci voted on patch set 13 V +1 01/13/22, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22011
-
Christian Kuhn uploaded patch set 14 01/13/22, 10:48
-
core-ci voted on patch set 14 V -1 01/13/22, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22013
-
Christian Kuhn uploaded patch set 15 01/13/22, 10:54
-
Christian Kuhn updated the commit message in patch set 16 01/13/22, 10:56
-
core-ci voted on patch set 15 V +1 01/13/22, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22014
-
core-ci voted on patch set 16 V -1 01/13/22, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22015
-
core-ci voted on patch set 16 V +1 01/13/22, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22015
-
Anja Leichsenring voted on patch set 16 V +1 CR +1 01/13/22, 19:03
-
Benni Mack voted on patch set 16 V +1 CR +1 01/13/22, 19:55
-
Stefan Bürk commented on patch set 16 CR +1 01/13/22, 19:57
Only reading, not tested. -
Benni Mack commented on patch set 16 01/13/22, 19:57
Services.yaml:10in general, toolbar items should be tagged (and then set to true by default), and then avoiding registration -
Stefan Bürk voted on patch set 16 V +1 01/13/22, 19:59
-
Christian Kuhn commented on patch set 16 01/13/22, 20:00
Services.yaml:10Replyah true. will streamline them in an additional patch. -
Christian Kuhn voted on patch set 16 V +2 CR +2 01/13/22, 20:01
-
Christian Kuhn merged patch set 17 01/13/22, 20:01
-
Christian Kuhn commented on patch set 17 01/14/22, 08:52
Services.yaml:10ReplyDone