Review main Merged

72996[TASK] Modernize backend toolbar code

Christian Kuhn CR +2 V +2 Expert +554 −939 updated 01/14/22, 08:52

Commit message

* Use BackendTemplateView
* Hand over template to render as view->render('MyTemplate')
* Move shortcut templates to Toolbar sub folder
* Move LiveSearch JS to Toolbar sub folder
* Shortcut delete and edit are POST only
* Use DI in related controllers and ToolbarItems
* Declare strict_types=1
* Return and property types in PHP classes
* PageRenderer JS module loading via fluid, not PHP
* f:translate with full LLL: keys

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 37

Show 17 more files

Review log 2542

Show 917 earlier messages
  1. Christian Kuhn uploaded patch set 1 01/12/22, 11:47

  2. Christian Kuhn uploaded patch set 2 01/12/22, 11:52

  3. core-ci voted on patch set 1 V -1 01/12/22, 12:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21963

  4. core-ci voted on patch set 2 V -1 01/12/22, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21964

  5. Christian Kuhn uploaded patch set 3 01/12/22, 12:37

  6. core-ci voted on patch set 3 V -1 01/12/22, 12:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21968

  7. Christian Kuhn uploaded patch set 4 01/12/22, 13:21

  8. core-ci voted on patch set 4 V -1 01/12/22, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21969

  9. Christian Kuhn uploaded patch set 5 01/12/22, 15:47

  10. core-ci voted on patch set 5 V -1 01/12/22, 15:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21980

  11. Christian Kuhn uploaded patch set 6 01/12/22, 15:53

  12. Christian Kuhn uploaded patch set 7 01/12/22, 15:58

  13. core-ci voted on patch set 7 V -1 01/12/22, 16:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21983

  14. core-ci voted on patch set 6 V -1 01/12/22, 16:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21982

  15. Christian Kuhn uploaded patch set 8 01/12/22, 17:32

  16. Christian Kuhn uploaded patch set 9 01/12/22, 17:33

  17. core-ci voted on patch set 8 V -1 01/12/22, 17:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21990

  1. Christian Kuhn uploaded patch set 10 01/12/22, 17:48

  2. core-ci voted on patch set 9 V +1 01/12/22, 17:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21991

  3. core-ci voted on patch set 10 V +1 01/12/22, 18:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21992

  4. Christian Kuhn uploaded patch set 11 01/12/22, 18:31

  5. Christian Kuhn uploaded patch set 12 01/12/22, 18:33

  6. core-ci voted on patch set 11 V -1 01/12/22, 18:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21993

  7. core-ci voted on patch set 12 V +1 01/12/22, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21994

  8. Christian Kuhn uploaded patch set 13 01/13/22, 09:53

  9. core-ci voted on patch set 13 V +1 01/13/22, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22011

  10. Christian Kuhn uploaded patch set 14 01/13/22, 10:48

  11. core-ci voted on patch set 14 V -1 01/13/22, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22013

  12. Christian Kuhn uploaded patch set 15 01/13/22, 10:54

  13. Christian Kuhn updated the commit message in patch set 16 01/13/22, 10:56

  14. core-ci voted on patch set 15 V +1 01/13/22, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22014

  15. core-ci voted on patch set 16 V -1 01/13/22, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22015

  16. core-ci voted on patch set 16 V +1 01/13/22, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22015

  17. Anja Leichsenring voted on patch set 16 V +1 CR +1 01/13/22, 19:03

  18. Benni Mack voted on patch set 16 V +1 CR +1 01/13/22, 19:55

  19. Stefan Bürk commented on patch set 16 CR +1 01/13/22, 19:57

    Only reading, not tested.
  20. Benni Mack commented on patch set 16 01/13/22, 19:57

    Services.yaml:10

    in general, toolbar items should be tagged (and then set to true by default), and then avoiding registration
  21. Stefan Bürk voted on patch set 16 V +1 01/13/22, 19:59

  22. Christian Kuhn commented on patch set 16 01/13/22, 20:00

    Services.yaml:10 Reply

    ah true. will streamline them in an additional patch.
  23. Christian Kuhn voted on patch set 16 V +2 CR +2 01/13/22, 20:01

  24. Christian Kuhn merged patch set 17 01/13/22, 20:01

  25. Christian Kuhn commented on patch set 17 01/14/22, 08:52

    Services.yaml:10 Reply

    Done