72997[!!!][TASK] Enforce non-empty configuration in cObj::parseFunc
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96520-EnforceNon-emptyConfigurationInCObjparseFunc.rst2new+95 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlViewHelper.php+1 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/HtmlViewHelperTest.php+49 −10
- typo3/sysext/fluid_styled_content/Tests/Functional/Rendering/Fixtures/FluidTemplate.html+0 −6
- typo3/sysext/fluid_styled_content/Tests/Functional/Rendering/SecureHtmlRenderingTest.php+2 −1
- typo3/sysext/fluid_styled_content/Tests/FunctionalDeprecated/Rendering/Fixtures/FluidTemplate.html+0 −6
- typo3/sysext/fluid_styled_content/Tests/FunctionalDeprecated/Rendering/SecureHtmlRenderingTest.php+4 −55
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+7 −9
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php+1 −1
Review log 1321
-
Oliver Hader uploaded patch set 1 01/12/22, 12:23
-
core-ci voted on patch set 1 V -1 01/12/22, 12:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21966
-
Oliver Hader uploaded patch set 2 01/12/22, 13:24
-
core-ci voted on patch set 2 V +1 01/12/22, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21970
-
Oliver Hader updated the commit message in patch set 3 01/12/22, 13:40
-
Oliver Hader uploaded patch set 4 01/12/22, 13:47
-
core-ci voted on patch set 3 V +1 01/12/22, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21973
-
core-ci voted on patch set 4 V +1 01/12/22, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21974
-
Oliver Hader uploaded patch set 5 01/12/22, 14:31
-
Oliver Hader uploaded patch set 6 01/12/22, 14:35
-
core-ci voted on patch set 5 V -1 01/12/22, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21976
-
core-ci voted on patch set 6 V +1 01/12/22, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21978
-
Georg Ringer commented on patch set 6 01/13/22, 11:22
This change is ready for review.Breaking-96520-EnforceNon-emptyConfigurationInCObjparseFunc.rst:86I guess users are more interested in using format.html for converting e.g. links. So maybe also point to f:transform.html which is certainly not really well known in the community -
Benni Mack commented on patch set 7 01/20/22, 18:57
Published edit on patch set 6. -
Benni Mack commented on patch set 7 V +1 CR +1 01/20/22, 18:57
Breaking-96520-EnforceNon-emptyConfigurationInCObjparseFunc.rst:86ReplyDone -
core-ci voted on patch set 7 V +1 01/20/22, 19:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22316
-
Benjamin Franzke uploaded patch set 8 01/21/22, 12:15
-
core-ci voted on patch set 8 V +1 01/21/22, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22347
-
Benni Mack voted on patch set 8 V +1 CR +1 01/21/22, 12:28
-
Benjamin Franzke voted on patch set 8 V +2 CR +2 01/21/22, 12:29
-
Benjamin Franzke merged patch set 9 01/21/22, 12:29