Review main Merged Breaking

72997[!!!][TASK] Enforce non-empty configuration in cObj::parseFunc

Oliver Hader CR +2 V +2 Normal +159 −89 updated 01/21/22, 12:29

Commit message

Invoking ContentObjectRenderer::parseFunc without configuration
or TypoScript reference is not possible anymore and in general
did not make much sense.

Calling this method without any instructions led to various
side-effects, e.g. unintentionally enforcing typo3/html-sanitizer.
This problem was amplified when using <f:format.html parseFuncTSPath="">
with an explicitly empty reference which actually did not do anything
and behaved the same as <f:format.raw>.

This change enforces that parseFunc is only invoked with actual
instructions. An empty configuration will throw a LogicException and
requires corresponding source code or Fluid templates to be adjusted.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1321

  1. Oliver Hader uploaded patch set 1 01/12/22, 12:23

  2. core-ci voted on patch set 1 V -1 01/12/22, 12:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21966

  3. Oliver Hader uploaded patch set 2 01/12/22, 13:24

  4. core-ci voted on patch set 2 V +1 01/12/22, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21970

  5. Oliver Hader updated the commit message in patch set 3 01/12/22, 13:40

  6. Oliver Hader uploaded patch set 4 01/12/22, 13:47

  7. core-ci voted on patch set 3 V +1 01/12/22, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21973

  8. core-ci voted on patch set 4 V +1 01/12/22, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21974

  9. Oliver Hader uploaded patch set 5 01/12/22, 14:31

  10. Oliver Hader uploaded patch set 6 01/12/22, 14:35

  11. core-ci voted on patch set 5 V -1 01/12/22, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21976

  12. core-ci voted on patch set 6 V +1 01/12/22, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21978

  13. Georg Ringer commented on patch set 6 01/13/22, 11:22

    This change is ready for review.

    Breaking-96520-EnforceNon-emptyConfigurationInCObjparseFunc.rst:86

    I guess users are more interested in using format.html for converting e.g. links. So maybe also point to f:transform.html which is certainly not really well known in the community
  14. Benni Mack commented on patch set 7 01/20/22, 18:57

    Published edit on patch set 6.
  15. Benni Mack commented on patch set 7 V +1 CR +1 01/20/22, 18:57

    Breaking-96520-EnforceNon-emptyConfigurationInCObjparseFunc.rst:86 Reply

    Done
  16. core-ci voted on patch set 7 V +1 01/20/22, 19:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22316

  17. Benjamin Franzke uploaded patch set 8 01/21/22, 12:15

  18. core-ci voted on patch set 8 V +1 01/21/22, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22347

  19. Benni Mack voted on patch set 8 V +1 CR +1 01/21/22, 12:28

  20. Benjamin Franzke voted on patch set 8 V +2 CR +2 01/21/22, 12:29

  21. Benjamin Franzke merged patch set 9 01/21/22, 12:29