Review main Merged Breaking

73000[!!!][TASK] Remove constants TYPO3_version and TYPO3_branch

Christian Kuhn CR +2 V +2 Easy +18 −21 updated 01/12/22, 20:16

Commit message

Global constants TYPO3_version and TYPO3_branch have
been deprecated with introduction of class
\TYPO3\CMS\Core\Information\Typo3Version in v9.5.15
and are removed together with some last usages.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 710

  1. Christian Kuhn uploaded patch set 1 01/12/22, 16:16

  2. Benni Mack updated the commit message in patch set 2 01/12/22, 16:21

  3. core-ci voted on patch set 1 V +1 01/12/22, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21984

  4. core-ci voted on patch set 2 V +1 01/12/22, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21985

  5. Benni Mack voted on patch set 2 V +1 CR +1 01/12/22, 19:53

  6. Oli Bartsch uploaded patch set 3 01/12/22, 19:54

  7. Oli Bartsch voted on patch set 3 V +1 CR +1 01/12/22, 19:55

  8. core-ci voted on patch set 3 V +1 01/12/22, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21996

  9. Benni Mack voted on patch set 3 V +2 CR +2 01/12/22, 20:16

  10. Benni Mack merged patch set 4 01/12/22, 20:16