Review main Merged

73002[TASK] Deprecate inline JavaScript in Dashboard

Oliver Hader CR +2 V +2 Normal +93 −5 updated 01/12/22, 20:37

Commit message

Using inline JavaScript when initializing RequireJS modules in
individual dashboard widgets has been deprecated. Widget
implementations have to be adjusted accordingly.

Basically `RequireJsModuleInterface` has to be replaced by
`JavaScriptInterface` relying on `JavaScriptModuleInstruction`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 45

  1. Oliver Hader uploaded patch set 1 01/12/22, 17:01

  2. core-ci voted on patch set 1 V +1 01/12/22, 17:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21987

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 01/12/22, 18:27

  4. Benni Mack voted on patch set 1 V +2 CR +2 01/12/22, 20:37

  5. Benni Mack merged patch set 2 01/12/22, 20:37