Review main Merged Breaking

73003[!!!][FEATURE] Add PSR-14 event to modify page module content

Oli Bartsch CR +2 V +2 Hard +291 −88 updated 01/13/22, 13:09

Commit message

This introduces a new PSR-14 event, enabling extension
authors to modify the header and footer content of the
page module in a flexible way, since also reordering
and overwriting is possible now.

This replaces the previously available hooks

- $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/db_layout.php']['drawHeaderHook']
- $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/db_layout.php']['drawFooterHook']

which are now removed.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 811

  1. Oli Bartsch uploaded patch set 1 01/12/22, 23:04

  2. core-ci voted on patch set 1 V +1 01/12/22, 23:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22000

  3. Oli Bartsch uploaded patch set 2 01/12/22, 23:55

  4. core-ci voted on patch set 2 V +1 01/13/22, 00:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22001

  5. Benjamin Franzke commented on patch set 2 CR +1 01/13/22, 08:54

    Feature-96526-PSR-14EventForModifyingPageModuleContent.rst:50

    -d
  6. Oli Bartsch uploaded patch set 3 01/13/22, 09:54

  7. Oli Bartsch commented on patch set 3 01/13/22, 09:54

    Feature-96526-PSR-14EventForModifyingPageModuleContent.rst:50 Reply

    Done
  8. core-ci voted on patch set 3 V +1 01/13/22, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22012

  9. Georg Ringer voted on patch set 3 V +1 CR +1 01/13/22, 10:47

  10. Benjamin Franzke voted on patch set 3 V +2 CR +2 01/13/22, 13:09

  11. Benjamin Franzke merged patch set 4 01/13/22, 13:09