Review main Merged

73005[TASK] Avoid request in ext:install view

Christian Kuhn CR +2 V +2 Hard +113 −138 updated 01/13/22, 16:46

Commit message

* Use BackendTemplateView and ->render('MyTemplate')
* f:translate with full LLL: keys
* No extbase-only f:form VH usages

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 11

Review log 911

  1. Christian Kuhn uploaded patch set 1 01/13/22, 12:05

  2. core-ci voted on patch set 1 V +1 01/13/22, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22016

  3. Oli Bartsch commented on patch set 1 01/13/22, 15:54

    AbstractController.php:39

    Can this be omitted like you did it in InstallerController?
  4. Christian Kuhn commented on patch set 1 01/13/22, 16:03

    AbstractController.php:39 Reply

    probably. will check.
  5. Christian Kuhn uploaded patch set 2 01/13/22, 16:06

  6. Christian Kuhn commented on patch set 2 01/13/22, 16:06

    AbstractController.php:39 Reply

    Done
  7. Oli Bartsch voted on patch set 2 V +1 CR +1 01/13/22, 16:15

  8. core-ci voted on patch set 2 V +1 01/13/22, 16:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22031

  9. Jochen Roth voted on patch set 2 V +1 CR +1 01/13/22, 16:45

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 01/13/22, 16:46

  11. Christian Kuhn merged patch set 3 01/13/22, 16:46