73006[TASK] Use dependency injection in ext:sys_note
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/sys_note/Classes/Domain/Repository/SysNoteRepository.php+13 −11
- typo3/sysext/sys_note/Classes/Hook/InfoModuleHook.php+9 −4
- typo3/sysext/sys_note/Classes/Provider/PageModuleProvider.php+6 −6
- typo3/sysext/sys_note/Classes/Provider/RecordListProvider.php+6 −6
- typo3/sysext/sys_note/Classes/Renderer/NoteRenderer.phprenamed+6 −6
- typo3/sysext/sys_note/Configuration/Services.yaml6+4 −0
- typo3/sysext/sys_note/Tests/Functional/Tca/NoteVisibleFieldsTest.php+2 −3
Review log 1723
-
Christian Kuhn uploaded patch set 1 01/13/22, 12:34
-
core-ci voted on patch set 1 V -1 01/13/22, 12:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22018
-
Benjamin Franzke uploaded patch set 2 01/13/22, 12:45
-
Benjamin Franzke wrote 01/13/22, 12:45
Topic set to di -
core-ci voted on patch set 2 V +1 01/13/22, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22019
-
Benjamin Franzke uploaded patch set 3 01/13/22, 13:11
Rebase -
Benjamin Franzke uploaded patch set 4 01/13/22, 13:15
Rebase -
core-ci voted on patch set 4 V +1 01/13/22, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22021
-
Oli Bartsch commented on patch set 4 V +1 01/13/22, 15:01
NoteController.php:38Any specific reason for using a new line here? Usually this is only done in case the parameters exceed the line length limit.Services.yaml:10This configuration is superfluous, since NoteController is now always injected. -
Christian Kuhn commented on patch set 4 01/13/22, 15:25
NoteController.php:38ReplyDoneServices.yaml:10ReplyAh, and never called directly as route. ok. -
Christian Kuhn uploaded patch set 5 01/13/22, 15:25
-
Christian Kuhn uploaded patch set 6 01/13/22, 15:27
-
Benjamin Franzke commented on patch set 4 V +1 CR +1 01/13/22, 15:27
Services.yaml:10ReplyGood catch. Maybe rename to NoteRenderer, while at it? Controller doesn't really make sense then, right? -
core-ci voted on patch set 5 V -1 01/13/22, 15:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22026
-
core-ci voted on patch set 6 V -1 01/13/22, 15:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22027
-
Benjamin Franzke commented on patch set 6 CR -1 01/13/22, 15:32
on it -
Christian Kuhn commented on patch set 6 01/13/22, 15:35
Services.yaml:10Replygood point. that broken name nagged me too, but i didn't go ahead to change it. -
Benjamin Franzke uploaded patch set 7 01/13/22, 15:37
-
Benjamin Franzke commented on patch set 7 01/13/22, 15:42
Services.yaml:10ReplyDone -
Oli Bartsch commented on patch set 7 V +1 CR +1 01/13/22, 15:43
Services.yaml:10ReplyDone -
core-ci voted on patch set 7 V +1 01/13/22, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22029
-
Oli Bartsch voted on patch set 7 V +2 CR +2 01/13/22, 15:55
-
Oli Bartsch merged patch set 8 01/13/22, 15:55