Review main Merged

73006[TASK] Use dependency injection in ext:sys_note

Christian Kuhn CR +2 V +2 Normal +46 −36 updated 01/13/22, 15:55

Commit message

Configure classes in Services.yaml towards dependency injection.

Also rename NoteController to NoteRenderer as it's not really a
controller that handles requests, but just a renderer used as
dependency in events. Controllers are usually public DI services,
renderes not.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1723

  1. Christian Kuhn uploaded patch set 1 01/13/22, 12:34

  2. core-ci voted on patch set 1 V -1 01/13/22, 12:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22018

  3. Benjamin Franzke uploaded patch set 2 01/13/22, 12:45

  4. Benjamin Franzke wrote 01/13/22, 12:45

    Topic set to di
  5. core-ci voted on patch set 2 V +1 01/13/22, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22019

  6. Benjamin Franzke uploaded patch set 3 01/13/22, 13:11

    Rebase
  7. Benjamin Franzke uploaded patch set 4 01/13/22, 13:15

    Rebase
  8. core-ci voted on patch set 4 V +1 01/13/22, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22021

  9. Oli Bartsch commented on patch set 4 V +1 01/13/22, 15:01

    NoteController.php:38

    Any specific reason for using a new line here? Usually this is only done in case the parameters exceed the line length limit.

    Services.yaml:10

    This configuration is superfluous, since NoteController is now always injected.
  10. Christian Kuhn commented on patch set 4 01/13/22, 15:25

    NoteController.php:38 Reply

    Done

    Services.yaml:10 Reply

    Ah, and never called directly as route. ok.
  11. Christian Kuhn uploaded patch set 5 01/13/22, 15:25

  12. Christian Kuhn uploaded patch set 6 01/13/22, 15:27

  13. Benjamin Franzke commented on patch set 4 V +1 CR +1 01/13/22, 15:27

    Services.yaml:10 Reply

    Good catch. Maybe rename to NoteRenderer, while at it? Controller doesn't really make sense then, right?
  14. core-ci voted on patch set 5 V -1 01/13/22, 15:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22026

  15. core-ci voted on patch set 6 V -1 01/13/22, 15:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22027

  16. Benjamin Franzke commented on patch set 6 CR -1 01/13/22, 15:32

    on it
  17. Christian Kuhn commented on patch set 6 01/13/22, 15:35

    Services.yaml:10 Reply

    good point. that broken name nagged me too, but i didn't go ahead to change it.
  18. Benjamin Franzke uploaded patch set 7 01/13/22, 15:37

  19. Benjamin Franzke commented on patch set 7 01/13/22, 15:42

    Services.yaml:10 Reply

    Done
  20. Oli Bartsch commented on patch set 7 V +1 CR +1 01/13/22, 15:43

    Services.yaml:10 Reply

    Done
  21. core-ci voted on patch set 7 V +1 01/13/22, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22029

  22. Oli Bartsch voted on patch set 7 V +2 CR +2 01/13/22, 15:55

  23. Oli Bartsch merged patch set 8 01/13/22, 15:55