Review main Merged

73007[TASK] Modernize ext:lowlevel view

Christian Kuhn CR +2 V +2 Hard +407 −470 updated 01/13/22, 19:01

Commit message

This is a partial refactoring of ext:lowlevel. There
are some loose ends like HTML in the searchAction()
and some other details. Those might be target of a
bigger refactoring. However, the patch cleans up
controller and view and improves separation of
concerns already:

* Rename mainAction() to handleRequest()
* Use BackendTemplateView
* Hand over template to render as view->render('MyTemplate')
* Use DI in related controllers
* Switch from a ServiceProvider.php to casual Services.yaml
* Declare strict_types=1
* Return and property types in PHP classes
* PageRenderer JS module loading via fluid, not PHP
* f:translate with full LLL: keys

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 20

Review log 1218

  1. Christian Kuhn uploaded patch set 1 01/13/22, 13:34

  2. core-ci voted on patch set 1 V +1 01/13/22, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22022

  3. Christian Kuhn uploaded patch set 2 01/13/22, 15:23

  4. Christian Kuhn updated the commit message in patch set 3 01/13/22, 15:33

  5. core-ci voted on patch set 2 V -1 01/13/22, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22025

  6. core-ci voted on patch set 3 V -1 01/13/22, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22028

  7. Christian Kuhn uploaded patch set 4 01/13/22, 16:03

  8. Christian Kuhn commented on patch set 4 CR -1 01/13/22, 16:09

    DatabaseIntegrityController.php:160

    ... missed these GU:_GP() calls ...
  9. core-ci voted on patch set 4 V +1 01/13/22, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22030

  10. Christian Kuhn uploaded patch set 5 01/13/22, 16:26

  11. Christian Kuhn commented on patch set 5 01/13/22, 16:27

    DatabaseIntegrityController.php:160 Reply

    Done
  12. core-ci voted on patch set 5 V -1 01/13/22, 16:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22032

  13. Christian Kuhn uploaded patch set 6 01/13/22, 16:45

  14. core-ci voted on patch set 6 V +1 01/13/22, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22033

  15. Stefan Bürk voted on patch set 6 V +1 CR +1 01/13/22, 18:58

  16. Anja Leichsenring voted on patch set 6 V +1 CR +1 01/13/22, 19:01

  17. Christian Kuhn voted on patch set 6 V +2 CR +2 01/13/22, 19:01

  18. Christian Kuhn merged patch set 7 01/13/22, 19:01