Review 11.5 Merged

73009[BUGFIX] Streamline typehints of variadic arguments in QueryBuilder

Christian Kuhn CR +2 V +2 Easy +8 −8 updated 01/13/22, 18:55

Commit message

Doctrine uses mixed type for most of their method arguments in
QueryBuilder. Since TYPO3 core uses variadic arguments for some
methods in the wrapping QueryBuilder, argument types have been
streamlined to match the ones in the concrete QueryBuilder
instance from Doctrine.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 01/13/22, 18:24

  2. core-ci voted on patch set 1 V +1 01/13/22, 18:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22035

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 01/13/22, 18:55

  4. Christian Kuhn merged patch set 2 01/13/22, 18:55