73011[TASK] Unify PageTsConfig loading
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+4 −44
- typo3/sysext/backend/Tests/Unit/Utility/BackendUtilityTest.php+5 −6
- typo3/sysext/core/Classes/Configuration/Loader/PageTsConfigLoader.php+1 −4
- typo3/sysext/core/Classes/Configuration/Parser/PageTsConfigParser.php+2 −9
- typo3/sysext/core/Classes/Configuration/PageTsConfig.phpnew+88 −0
- typo3/sysext/core/Configuration/Services.yaml2+10 −0
- typo3/sysext/core/Tests/Unit/Localization/TcaSystemLanguageCollectorTest.php+10 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+9 −17
Review log 1318
-
Benni Mack uploaded patch set 1 01/13/22, 20:57
-
core-ci voted on patch set 1 V -1 01/13/22, 21:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22040
-
Benni Mack uploaded patch set 2 01/14/22, 14:07
-
core-ci voted on patch set 2 V -1 01/14/22, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22065
-
Benni Mack uploaded patch set 3 01/14/22, 14:30
-
core-ci voted on patch set 3 V +1 01/14/22, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22066
-
Benjamin Franzke commented on patch set 3 01/14/22, 15:20
-
Christian Kuhn commented on patch set 3 01/14/22, 15:30
nice. give me a chance to review this in detail, please.issue missing -
Benni Mack commented on patch set 3 CR -2 01/14/22, 16:16
will update soonish -
Benni Mack updated the commit message in patch set 4 01/14/22, 19:01
-
Benni Mack commented on patch set 5 01/14/22, 19:01
Published edit on patch set 4. -
Benni Mack commented on patch set 5 CR 0 01/14/22, 19:02
Reply
THX!Services.yaml:72ReplyAgain what learned, tried it out in another patch already, thanks for the pointer. -
Christian Kuhn voted on patch set 5 V +1 CR +1 01/14/22, 19:15
-
Stefan Bürk voted on patch set 5 V +1 CR +1 01/14/22, 19:15
-
core-ci voted on patch set 4 V +1 01/14/22, 19:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22083
-
core-ci voted on patch set 5 V +1 01/14/22, 19:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22084
-
Christian Kuhn voted on patch set 5 V +2 CR +2 01/14/22, 19:21
-
Christian Kuhn merged patch set 6 01/14/22, 19:21
Services.yaml:72