Review main Merged

73011[TASK] Unify PageTsConfig loading

Benni Mack CR +2 V +2 Normal +129 −80 updated 01/14/22, 19:21

Commit message

This change adds a new centralized place
in TYPO3\CMS\Core\Configuration\PageTsConfig to
load and parse (and match) PageTsConfig for Frontend
and Backend.

This way, the class can now be injected into
various places and reduce the usages to
"BackendUtility::getPagesTSconfig()"

Once all usages have been reduced, the main
BackendUtility method can be deprecated.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1318

  1. Benni Mack uploaded patch set 1 01/13/22, 20:57

  2. core-ci voted on patch set 1 V -1 01/13/22, 21:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22040

  3. Benni Mack uploaded patch set 2 01/14/22, 14:07

  4. core-ci voted on patch set 2 V -1 01/14/22, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22065

  5. Benni Mack uploaded patch set 3 01/14/22, 14:30

  6. core-ci voted on patch set 3 V +1 01/14/22, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22066

  7. Benjamin Franzke commented on patch set 3 01/14/22, 15:20

    Services.yaml:72

    $loader and $parser should be auto-injectable, right? both lines can probably be removed.
  8. Christian Kuhn commented on patch set 3 01/14/22, 15:30

    nice. give me a chance to review this in detail, please.
    issue missing
  9. Benni Mack commented on patch set 3 CR -2 01/14/22, 16:16

    will update soonish
  10. Benni Mack updated the commit message in patch set 4 01/14/22, 19:01

  11. Benni Mack commented on patch set 5 01/14/22, 19:01

    Published edit on patch set 4.
  12. Benni Mack commented on patch set 5 CR 0 01/14/22, 19:02

    Reply

    THX!

    Services.yaml:72 Reply

    Again what learned, tried it out in another patch already, thanks for the pointer.
  13. Christian Kuhn voted on patch set 5 V +1 CR +1 01/14/22, 19:15

  14. Stefan Bürk voted on patch set 5 V +1 CR +1 01/14/22, 19:15

  15. core-ci voted on patch set 4 V +1 01/14/22, 19:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22083

  16. core-ci voted on patch set 5 V +1 01/14/22, 19:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22084

  17. Christian Kuhn voted on patch set 5 V +2 CR +2 01/14/22, 19:21

  18. Christian Kuhn merged patch set 6 01/14/22, 19:21