Review main Merged

73012[TASK] Modernize ext:viewpage view

Christian Kuhn CR +2 V +2 Hard +174 −249 updated 01/14/22, 17:56

Commit message

* Rename mainAction() to handleRequest()
* Use BackendTemplateView
* Hand over template to render as view->render('MyTemplate')
* Return and property types in PHP classes
* PageRenderer JS module loading via fluid, not PHP
* f:translate with full LLL: keys
* FlashMesage rendering via ModuleTemplate

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1421

  1. Christian Kuhn uploaded patch set 1 01/13/22, 21:02

  2. Christian Kuhn uploaded patch set 2 01/13/22, 21:12

  3. core-ci voted on patch set 1 V -1 01/13/22, 21:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22042

  4. core-ci voted on patch set 2 V -1 01/13/22, 21:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22043

  5. Christian Kuhn uploaded patch set 3 01/14/22, 11:30

  6. core-ci voted on patch set 3 V +1 01/14/22, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22055

  7. Benni Mack voted on patch set 3 V +1 CR +1 01/14/22, 13:45

  8. Oli Bartsch commented on patch set 3 01/14/22, 14:00

    ViewModuleController.php:110

    IMO at this point we should skip the the whole code below, not only the doc header generation. None of the variables below will be used in the template in this case. I suggest to initialize the view above and in case $canRenderMainBody is FALSE, we make an early return here with: $moduleTemplate->setContent($view->assign('canRenderContent', false)->render('Show')); return new HtmlResponse($moduleTemplate->renderContent()); What do you think?
  9. Christian Kuhn commented on patch set 3 01/14/22, 15:01

    ViewModuleController.php:110 Reply

    actually, that's similar how it was done before, and i removed the early return by intention: i want only one render() call and the view assignments don't harm at this point. is that ok with you?
  10. Christian Kuhn uploaded patch set 4 01/14/22, 15:12

  11. Christian Kuhn uploaded patch set 5 01/14/22, 15:13

  12. Christian Kuhn commented on patch set 5 01/14/22, 15:14

    ViewModuleController.php:110 Reply

    Ok. Changed slightly, but done.
  13. core-ci voted on patch set 4 V -1 01/14/22, 15:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22070

  14. core-ci voted on patch set 5 V -1 01/14/22, 15:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22071

  15. Christian Kuhn uploaded patch set 6 01/14/22, 15:17

  16. Oli Bartsch voted on patch set 6 V +1 CR +1 01/14/22, 15:28

  17. core-ci voted on patch set 6 V -1 01/14/22, 15:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22072

  18. core-ci voted on patch set 6 V +1 01/14/22, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22072

  19. Stefan Bürk voted on patch set 6 V +1 CR +1 01/14/22, 17:55

  20. Christian Kuhn voted on patch set 6 V +2 CR +2 01/14/22, 17:56

  21. Christian Kuhn merged patch set 7 01/14/22, 17:56