73012[TASK] Modernize ext:viewpage view
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 4
Review log 1421
-
Christian Kuhn uploaded patch set 1 01/13/22, 21:02
-
Christian Kuhn uploaded patch set 2 01/13/22, 21:12
-
core-ci voted on patch set 1 V -1 01/13/22, 21:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22042
-
core-ci voted on patch set 2 V -1 01/13/22, 21:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22043
-
Christian Kuhn uploaded patch set 3 01/14/22, 11:30
-
core-ci voted on patch set 3 V +1 01/14/22, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22055
-
Benni Mack voted on patch set 3 V +1 CR +1 01/14/22, 13:45
-
Oli Bartsch commented on patch set 3 01/14/22, 14:00
-
Christian Kuhn commented on patch set 3 01/14/22, 15:01
ViewModuleController.php:110Replyactually, that's similar how it was done before, and i removed the early return by intention: i want only one render() call and the view assignments don't harm at this point. is that ok with you? -
Christian Kuhn uploaded patch set 4 01/14/22, 15:12
-
Christian Kuhn uploaded patch set 5 01/14/22, 15:13
-
Christian Kuhn commented on patch set 5 01/14/22, 15:14
ViewModuleController.php:110ReplyOk. Changed slightly, but done. -
core-ci voted on patch set 4 V -1 01/14/22, 15:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22070
-
core-ci voted on patch set 5 V -1 01/14/22, 15:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22071
-
Christian Kuhn uploaded patch set 6 01/14/22, 15:17
-
Oli Bartsch voted on patch set 6 V +1 CR +1 01/14/22, 15:28
-
core-ci voted on patch set 6 V -1 01/14/22, 15:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22072
-
core-ci voted on patch set 6 V +1 01/14/22, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22072
-
Stefan Bürk voted on patch set 6 V +1 CR +1 01/14/22, 17:55
-
Christian Kuhn voted on patch set 6 V +2 CR +2 01/14/22, 17:56
-
Christian Kuhn merged patch set 7 01/14/22, 17:56
ViewModuleController.php:110