73014[TASK] Avoid resolving first optional argument as content overrule
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 12
- typo3/sysext/core/Classes/ViewHelpers/NormalizedUrlViewHelper.php+9 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/InfoboxViewHelper.php+8 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/BytesViewHelper.php2+8 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/DateViewHelper.php+8 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlentitiesDecodeViewHelper.php+8 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlentitiesViewHelper.php+8 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/JsonViewHelper.php+8 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/Nl2brViewHelper.php+9 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/PaddingViewHelper.php+8 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/StripTagsViewHelper.php+9 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/UrlencodeViewHelper.php+9 −1
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php+9 −1
Review log 1319
-
Stefan Bürk uploaded patch set 1 01/13/22, 21:38
-
core-ci voted on patch set 1 V -1 01/13/22, 21:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22046
-
Stefan Bürk commented on patch set 1 01/14/22, 22:11
Needs fix in typo3 fluid first: Pull-Request: https://github.com/TYPO3/Fluid/pull/583 Issue: https://github.com/TYPO3/Fluid/issues/582 This must be approved and a new version released, which needs to be raised in core afterwards. -
Stefan Bürk uploaded patch set 2 01/18/22, 17:34
-
core-ci voted on patch set 2 V +1 01/18/22, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22232
-
Stefan Bürk uploaded patch set 3 01/18/22, 18:33
-
core-ci voted on patch set 3 V +1 01/18/22, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22234
-
Stefan Bürk marked it ready for review 01/18/22, 23:18
-
Stefan Bürk updated the commit message in patch set 4 01/18/22, 23:20
-
core-ci voted on patch set 4 V +1 01/18/22, 23:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22239
-
Christian Kuhn updated the commit message in patch set 5 01/19/22, 00:41
-
Christian Kuhn commented on patch set 5 01/19/22, 00:44
BytesViewHelper.php:82should be removed. -
Christian Kuhn uploaded patch set 6 01/19/22, 00:49
-
Christian Kuhn commented on patch set 6 01/19/22, 00:49
BytesViewHelper.php:82ReplyDone -
core-ci voted on patch set 5 V +1 01/19/22, 00:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22243
-
Christian Kuhn voted on patch set 6 V +1 CR +1 01/19/22, 00:58
-
core-ci voted on patch set 6 V +1 01/19/22, 01:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22244
-
Benni Mack voted on patch set 6 V +2 CR +2 01/19/22, 07:04
-
Benni Mack merged patch set 7 01/19/22, 07:04