Review main Merged

73014[TASK] Avoid resolving first optional argument as content overrule

Stefan Bürk CR +2 V +2 Normal +101 −5 updated 01/19/22, 07:04

Commit message

Trait 'CompileWithContentArgumentAndRenderStatic' provides
magic handling trying to retrieve the first optional
registered argument as render children closure.
This can alse be set to property $contentArgumentName,
which is documented as recommended in the trait to
suppress magic.

The patch sets property $contentArgumentName to the
currently first optional argument in all ViewHelpers
by overriding traits 'resolveContentArgumentName()'.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 1319

  1. Stefan Bürk uploaded patch set 1 01/13/22, 21:38

  2. core-ci voted on patch set 1 V -1 01/13/22, 21:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22046

  3. Stefan Bürk commented on patch set 1 01/14/22, 22:11

    Needs fix in typo3 fluid first: Pull-Request: https://github.com/TYPO3/Fluid/pull/583 Issue: https://github.com/TYPO3/Fluid/issues/582 This must be approved and a new version released, which needs to be raised in core afterwards.
  4. Stefan Bürk uploaded patch set 2 01/18/22, 17:34

  5. core-ci voted on patch set 2 V +1 01/18/22, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22232

  6. Stefan Bürk uploaded patch set 3 01/18/22, 18:33

  7. core-ci voted on patch set 3 V +1 01/18/22, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22234

  8. Stefan Bürk marked it ready for review 01/18/22, 23:18

  9. Stefan Bürk updated the commit message in patch set 4 01/18/22, 23:20

  10. core-ci voted on patch set 4 V +1 01/18/22, 23:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22239

  11. Christian Kuhn updated the commit message in patch set 5 01/19/22, 00:41

  12. Christian Kuhn commented on patch set 5 01/19/22, 00:44

    BytesViewHelper.php:82

    should be removed.
  13. Christian Kuhn uploaded patch set 6 01/19/22, 00:49

  14. Christian Kuhn commented on patch set 6 01/19/22, 00:49

    BytesViewHelper.php:82 Reply

    Done
  15. core-ci voted on patch set 5 V +1 01/19/22, 00:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22243

  16. Christian Kuhn voted on patch set 6 V +1 CR +1 01/19/22, 00:58

  17. core-ci voted on patch set 6 V +1 01/19/22, 01:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22244

  18. Benni Mack voted on patch set 6 V +2 CR +2 01/19/22, 07:04

  19. Benni Mack merged patch set 7 01/19/22, 07:04