Review main Merged

73015[TASK] Simplify RecyclerModuleController

Oli Bartsch CR +2 V +2 Hard +157 −281 updated 01/14/22, 12:44

Commit message

While the RecyclerModuleController does only
feature one action - indexAction - the handleRequest()
method still contained corresponding logic to
dynamically forward the request to another action.

This is now simplified together with a couple of
further cleanups, e.g. removal of unnecessary
class properties / methods and adding strict
types.

Additionally, the new BackendTemplateView is
now used instead of StandaloneView.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1419

  1. Oli Bartsch uploaded patch set 1 01/13/22, 22:52

  2. Oli Bartsch uploaded patch set 2 01/13/22, 22:57

  3. core-ci voted on patch set 1 V -1 01/13/22, 23:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22047

  4. core-ci voted on patch set 2 V -1 01/13/22, 23:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22048

  5. Oli Bartsch uploaded patch set 3 01/13/22, 23:54

  6. core-ci voted on patch set 3 V +1 01/14/22, 00:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22050

  7. Benni Mack voted on patch set 3 V +1 CR +1 01/14/22, 11:08

  8. Christian Kuhn commented on patch set 3 CR -1 01/14/22, 11:41

    i'll fiddle with some details.
  9. Christian Kuhn commented on patch set 3 01/14/22, 11:48

    RecyclerModuleController.php:46

    i tend to hand over the moduleTemplate to methods that need them to avoid this class state.

    RecyclerModuleController.php:84

    Note i personally try to avoid pageRenderer stuff within controllers and tend to move them to the template. In this case, with the amount of inline settings and the full inclusion of that language file (and more than 10 of the labels are actually used in JS), it's fine with me to set up the stuff in the controller, though, and avoid a f:pageRenderer VH usage in templates.
  10. Christian Kuhn commented on patch set 3 01/14/22, 11:57

    RecyclerModuleController.php:46 Reply

    Done

    RecyclerModuleController.php:76

    this is unused in JS

    RecyclerModuleController.php:84 Reply

    Done
  11. Christian Kuhn commented on patch set 3 01/14/22, 12:02

    RecyclerModuleController.php:78

    unused in js.

    RecyclerModuleController.php:82

    unused in js.
  12. Christian Kuhn uploaded patch set 4 01/14/22, 12:08

  13. Christian Kuhn commented on patch set 4 01/14/22, 12:09

    RecyclerModuleController.php:78 Reply

    Done

    RecyclerModuleController.php:82 Reply

    Done
  14. Christian Kuhn updated the commit message in patch set 5 01/14/22, 12:10

  15. core-ci voted on patch set 4 V -1 01/14/22, 12:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22057

  16. core-ci voted on patch set 5 V +1 01/14/22, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22058

  17. Christian Kuhn voted on patch set 5 V +1 CR +1 01/14/22, 12:28

  18. Benni Mack voted on patch set 5 V +2 CR +2 01/14/22, 12:44

  19. Benni Mack merged patch set 6 01/14/22, 12:44