73015[TASK] Simplify RecyclerModuleController
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php9+47 −174
- typo3/sysext/recycler/Resources/Private/Layouts/Default.htmldeleted+0 −3
- typo3/sysext/recycler/Resources/Private/Templates/RecyclerModule/Index.htmldeleted+0 −104
- typo3/sysext/recycler/Resources/Private/Templates/RecyclerModule.htmlnew+110 −0
Review log 1419
-
Oli Bartsch uploaded patch set 1 01/13/22, 22:52
-
Oli Bartsch uploaded patch set 2 01/13/22, 22:57
-
core-ci voted on patch set 1 V -1 01/13/22, 23:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22047
-
core-ci voted on patch set 2 V -1 01/13/22, 23:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22048
-
Oli Bartsch uploaded patch set 3 01/13/22, 23:54
-
core-ci voted on patch set 3 V +1 01/14/22, 00:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22050
-
Benni Mack voted on patch set 3 V +1 CR +1 01/14/22, 11:08
-
Christian Kuhn commented on patch set 3 CR -1 01/14/22, 11:41
i'll fiddle with some details. -
Christian Kuhn commented on patch set 3 01/14/22, 11:48
RecyclerModuleController.php:46i tend to hand over the moduleTemplate to methods that need them to avoid this class state.RecyclerModuleController.php:84Note i personally try to avoid pageRenderer stuff within controllers and tend to move them to the template. In this case, with the amount of inline settings and the full inclusion of that language file (and more than 10 of the labels are actually used in JS), it's fine with me to set up the stuff in the controller, though, and avoid a f:pageRenderer VH usage in templates. -
Christian Kuhn commented on patch set 3 01/14/22, 11:57
RecyclerModuleController.php:46ReplyDoneRecyclerModuleController.php:76this is unused in JSRecyclerModuleController.php:84ReplyDone -
Christian Kuhn commented on patch set 3 01/14/22, 12:02
RecyclerModuleController.php:78unused in js.RecyclerModuleController.php:82unused in js. -
Christian Kuhn uploaded patch set 4 01/14/22, 12:08
-
Christian Kuhn commented on patch set 4 01/14/22, 12:09
RecyclerModuleController.php:78ReplyDoneRecyclerModuleController.php:82ReplyDone -
Christian Kuhn updated the commit message in patch set 5 01/14/22, 12:10
-
core-ci voted on patch set 4 V -1 01/14/22, 12:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22057
-
core-ci voted on patch set 5 V +1 01/14/22, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22058
-
Christian Kuhn voted on patch set 5 V +1 CR +1 01/14/22, 12:28
-
Benni Mack voted on patch set 5 V +2 CR +2 01/14/22, 12:44
-
Benni Mack merged patch set 6 01/14/22, 12:44