Review main Merged

73016[TASK] Simplify EXT:redirects ManagementController

Oli Bartsch CR +2 V +2 Hard +149 −142 updated 01/14/22, 13:42

Commit message

While the ManagementController does only feature
one action - overviewAction - the handleRequest()
made a couple of unnecessary calls, especially to
the mentioned action.

This is now simplified together with a couple of
further cleanups, e.g. removal of unnecessary
class properties / methods.

Additionally, the new BackendTemplateView is
now used instead of StandaloneView, which
required a few changes in the template.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 68

  1. Oli Bartsch uploaded patch set 1 01/13/22, 23:51

  2. core-ci voted on patch set 1 V +1 01/14/22, 00:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22049

  3. Christian Kuhn commented on patch set 1 CR -1 01/14/22, 12:26

    i'll push some minor adaptions here as well.
  4. Christian Kuhn uploaded patch set 2 01/14/22, 13:01

  5. core-ci voted on patch set 2 V +1 01/14/22, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22061

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 01/14/22, 13:31

  7. Benni Mack voted on patch set 2 V +2 CR +2 01/14/22, 13:42

  8. Benni Mack merged patch set 3 01/14/22, 13:42