Review main Merged

73020[TASK] Modernize various ext:backend views

Christian Kuhn CR +2 V +2 Hard +239 −479 updated 01/14/22, 19:05

Commit message

A series of ext:backend related controllers and
views are cleaned up. Some of them need more work,
especially LoginController, BackendController and
NewRecordController. This can be done with further
patches, but for now:

* Use BackendTemplateView
* Hand over template to render as view->render('MyTemplate')
* Use DI in related controllers and ToolbarItems
* Declare strict_types=1
* Return and property types in PHP classes
* PageRenderer JS module loading via fluid, not PHP
* f:translate with full LLL: keys

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 17

Review log 1013

  1. Christian Kuhn uploaded patch set 1 01/14/22, 15:25

  2. core-ci voted on patch set 1 V +1 01/14/22, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22074

  3. Christian Kuhn uploaded patch set 2 01/14/22, 17:30

  4. Christian Kuhn commented on patch set 2 01/14/22, 17:33

    Avatar.php:76

    I inlined this html from the template since i'd like to avoid the scenario "fluid template -> avatar VH -> avatar class -> fluid template" for performance reasons here. And these couple of html tags are fine here, imho and shouldn't be changed by anyone - they all have proper classes and shouldn't be needed to be changed.

    Avatar.php:85

    note i made this protected since it does not make sense to call that method from the outside: the providers are not initialized and can't be initialized if calling this directly.
  5. Christian Kuhn uploaded patch set 3 01/14/22, 17:46

  6. core-ci voted on patch set 2 V -1 01/14/22, 17:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22077

  7. Christian Kuhn updated the commit message in patch set 4 01/14/22, 17:50

  8. core-ci voted on patch set 4 V +1 01/14/22, 18:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22079

  9. Stefan Bürk voted on patch set 4 CR +1 01/14/22, 18:35

  10. Stefan Bürk voted on patch set 4 V +1 01/14/22, 18:35

  11. Benni Mack voted on patch set 4 V +1 CR +1 01/14/22, 18:55

  12. Christian Kuhn voted on patch set 4 V +2 CR +2 01/14/22, 19:05

  13. Christian Kuhn merged patch set 5 01/14/22, 19:05