Review main Merged

73024[TASK] Use ES6 JavaScript module specifiers in InstallTool

Benjamin Franzke CR +2 V +2 Normal +31 −31 updated 01/21/22, 12:20

Commit message

Do no longer add the .js suffix in the javascript module, but
supply it via the templates and use a new data-import attribute
to reflect that we use native imports instead of RequireJS.

Template adaptions performed via:

  git grep -l data-require= typo3/sysext/install | \
    xargs sed -i 's/data-require="\([^"]*\)"/data-import="\1.js"/'

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 813

  1. Benjamin Franzke uploaded patch set 1 01/14/22, 22:59

  2. core-ci voted on patch set 1 V -1 01/14/22, 23:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22102

  3. core-ci voted on patch set 1 V +1 01/14/22, 23:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22102

  4. Benjamin Franzke uploaded patch set 2 01/18/22, 15:43

  5. core-ci voted on patch set 2 V +1 01/18/22, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22230

  6. Benjamin Franzke uploaded patch set 3 01/21/22, 09:25

  7. core-ci voted on patch set 3 V +1 01/21/22, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22336

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 01/21/22, 12:06

  9. Christian Kuhn updated the commit message in patch set 4 01/21/22, 12:06

  10. Christian Kuhn voted on patch set 4 V +1 CR +1 01/21/22, 12:06

  11. Andreas Kienast voted on patch set 4 V +2 CR +2 01/21/22, 12:17

  12. core-ci voted on patch set 4 V +1 01/21/22, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22346

  13. Andreas Kienast merged patch set 5 01/21/22, 12:20