73025[TASK] Support FLAG_USE_TOP_WINDOW for ESM instructions
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 12
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Utility/TopLevelModuleImport.tsnew+32 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/JavaScriptModuleImportEventHandler.tsnew+19 −0
- Build/Sources/TypeScript/core/Resources/Public/TypeScript/JavaScriptItemProcessor.ts+11 −2
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Settings/SystemMaintainer.ts+2 −1
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Upgrade/UpgradeDocs.ts+2 −1
- typo3/sysext/backend/Classes/Controller/BackendController.php+1 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Utility/TopLevelModuleImport.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/JavaScriptModuleImportEventHandler.jsnew+13 −0
- typo3/sysext/core/Resources/Public/JavaScript/JavaScriptItemProcessor.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Settings/SystemMaintainer.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Upgrade/UpgradeDocs.js+1 −1
- typo3/sysext/redirects/Classes/Hooks/DispatchNotificationHook.php+3 −2
Review log 1216
-
Benjamin Franzke uploaded patch set 1 01/14/22, 23:00
-
core-ci voted on patch set 1 V +1 01/14/22, 23:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22103
-
Benjamin Franzke uploaded patch set 2 01/21/22, 13:35
-
core-ci voted on patch set 2 V -1 01/21/22, 13:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22354
-
Christian Kuhn commented on patch set 2 01/21/22, 13:53
This looks cool, but I don't really understand the impact. This means JS modules are no longer loaded within the modules iframe, but loaded into the top frame instead? Does that mean, when I click the redirects module a second time, the module is not fetched a second time? Why is that triggered within ext:redirects with this one-liner change? I think it may help to just explain a bit more within the commit message - more tailored for people like me who are not that deep within the esm stuff ;) Note regarding install tool: Testing the patch means testing the standalone install tool as well. -
Benjamin Franzke commented on patch set 2 01/21/22, 13:57
Reply
will explain. This is for cases where the inner frame does stuff in the outer frame, like: * presenting a modal in the outer frame which requires "new" dependencies (in general that's quite ugly, but that's what we have for the system-maintainers modal when rendered inside the backend module) * presenting a notification in the outer frame For all other cases and regular imports this isn't used. -
Benjamin Franzke voted on patch set 2 CR -1 01/21/22, 14:07
-
Benjamin Franzke uploaded patch set 3 01/21/22, 14:22
-
Benjamin Franzke commented on patch set 3 01/21/22, 14:22
Reply
Done -
core-ci voted on patch set 3 V +1 01/21/22, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22356
-
Benni Mack voted on patch set 3 V +1 CR +1 01/21/22, 20:21
-
Benni Mack updated the commit message in patch set 4 01/21/22, 21:32
-
Benni Mack voted on patch set 4 V +1 CR +1 01/21/22, 21:32
-
core-ci voted on patch set 4 V +1 01/21/22, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22381
-
Christian Kuhn voted on patch set 4 V +2 CR +2 01/22/22, 19:23
-
Christian Kuhn merged patch set 5 01/22/22, 19:23