73026[TASK] Migrate Form Framework JavaScript and documentation to ES6
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 26
- Build/Sources/TypeScript/core/Resources/Public/TypeScript/JavaScriptItemProcessor.ts+4 −4
- Build/Sources/TypeScript/form/Resources/Public/TypeScript/Backend/Helper.ts+18 −11
- typo3/sysext/core/Documentation/Changelog/12.0/Deprecation-96568-RequireJSModulesInFormFramework.rst6new+67 −0
- typo3/sysext/core/Resources/Public/JavaScript/JavaScriptItemProcessor.js+1 −1
- typo3/sysext/form/Classes/Controller/FormEditorController.php+36 −8
- typo3/sysext/form/Classes/Controller/FormManagerController.php+23 −7
- typo3/sysext/form/Configuration/Yaml/FormSetup.yaml+7 −7
- typo3/sysext/form/Configuration/JavaScriptModules.php+1 −1
- typo3/sysext/form/Documentation/I/ApiReference/Index.rst+3 −3
- typo3/sysext/form/Documentation/I/Concepts/FormEditor/Index.rst+118 −128
- typo3/sysext/form/Documentation/I/Config/configuration/Index.rst+7 −7
- typo3/sysext/form/Documentation/I/Config/formManager/Index.rst+12 −12
- typo3/sysext/form/Documentation/I/Config/proto/formEditor/Index.rst+19 −19
- typo3/sysext/form/Resources/Public/JavaScript/Backend/Contrib/jquery.mjs.nestedSortable.js+4 −17
- typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/Core.js+25 −3
- typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/Helper.js+32 −3
- typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/InspectorComponent.js+62 −11
- typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/Mediator.js+12 −5
- typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/ModalsComponent.js+27 −8
- typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/StageComponent.js+65 −7
Show 6 more files
- typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/TreeComponent.js+39 −7
- typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/ViewModel.js+152 −12
- typo3/sysext/form/Resources/Public/JavaScript/Backend/FormManager/ViewModel.js+17 −10
- typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor.js+13 −6
- typo3/sysext/form/Resources/Public/JavaScript/Backend/FormManager.js+11 −3
- typo3/sysext/form/Resources/Public/JavaScript/Backend/Helper.js+1 −1
Review log 1926
Show 1 earlier messages
-
Benjamin Franzke uploaded patch set 1 01/14/22, 23:01
-
core-ci voted on patch set 1 V +1 01/14/22, 23:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22104
-
Benjamin Franzke uploaded patch set 2 01/18/22, 15:39
-
core-ci voted on patch set 2 V -1 01/18/22, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22229
-
core-ci voted on patch set 2 V +1 01/18/22, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22229
-
Benjamin Franzke uploaded patch set 3 01/18/22, 18:19
-
core-ci voted on patch set 3 V +1 01/18/22, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22233
-
Benjamin Franzke rebased onto patch set 4 01/21/22, 09:27
-
core-ci voted on patch set 4 V +1 01/21/22, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22339
-
Mathias Brodala commented on patch set 4 01/21/22, 09:47
-
Benjamin Franzke commented on patch set 4 01/21/22, 09:51
Deprecation-96568-RequireJSModulesInFormFramework.rst:50Replytrue, that may be confusing without context. we should add the corresponding importmap configuration as in https://review.typo3.org/c/Packages/TYPO3.CMS/+/73026/4/typo3/sysext/form/Documentation/I/Concepts/FormEditor/Index.rst#181 here -
Mathias Brodala commented on patch set 4 01/21/22, 09:56
Deprecation-96568-RequireJSModulesInFormFramework.rst:50ReplyAck -
Benjamin Franzke uploaded patch set 5 01/21/22, 09:57
-
Benjamin Franzke commented on patch set 5 01/21/22, 09:57
Deprecation-96568-RequireJSModulesInFormFramework.rst:50ReplyDone -
Mathias Brodala commented on patch set 5 CR -1 01/21/22, 10:04
Deprecation-96568-RequireJSModulesInFormFramework.rst:64This should use 4 space indentation (PSR-2), also "=" must be "=>". And we all love our little trailing comma. ;-) In any case this makes it way clearer, indeed. -
Benjamin Franzke uploaded patch set 6 01/21/22, 10:06
-
Benjamin Franzke commented on patch set 6 01/21/22, 10:06
Deprecation-96568-RequireJSModulesInFormFramework.rst:64Replyoops, sorry, done. -
Benjamin Franzke uploaded patch set 7 01/21/22, 10:07
-
core-ci voted on patch set 7 V +1 01/21/22, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22342
-
Benni Mack voted on patch set 7 V +1 CR +1 01/21/22, 21:04
-
Benjamin Franzke uploaded patch set 8 01/22/22, 19:50
Resolve Merge Conflict -
core-ci voted on patch set 8 V +1 01/22/22, 20:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22411
-
Benni Mack voted on patch set 8 V +1 CR +1 01/22/22, 20:46
-
Oli Bartsch voted on patch set 8 V +1 CR +1 01/25/22, 10:29
-
Benjamin Franzke voted on patch set 8 V +2 CR +2 01/25/22, 10:30
-
Benjamin Franzke merged patch set 9 01/25/22, 10:30
Deprecation-96568-RequireJSModulesInFormFramework.rst:50