Review main Merged

73026[TASK] Migrate Form Framework JavaScript and documentation to ES6

Benjamin Franzke CR +2 V +2 Expert +776 −301 updated 01/25/22, 10:30

Commit message

The module syntax is moved from AMD to ES6.
To avoid reindenting every javasscript line (>10000 LOC),
the existings factories are kept as-is and the exports
are spreaded from the factory result.

A new configuration option dynamicJavaScriptModules
is added to replace the previous dynamicRequireJsModules
functionality to incorparate for the new ES6 functionality
added in #96510 and #96511.

Also dynamicRequireJsModules is no longer passed to
the form editor and manager templates, as this variable
is a left over from #90867.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 26

Show 6 more files

Review log 1926

Show 1 earlier messages
  1. Benjamin Franzke uploaded patch set 1 01/14/22, 23:01

  1. core-ci voted on patch set 1 V +1 01/14/22, 23:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22104

  2. Benjamin Franzke uploaded patch set 2 01/18/22, 15:39

  3. core-ci voted on patch set 2 V -1 01/18/22, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22229

  4. core-ci voted on patch set 2 V +1 01/18/22, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22229

  5. Benjamin Franzke uploaded patch set 3 01/18/22, 18:19

  6. core-ci voted on patch set 3 V +1 01/18/22, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22233

  7. Benjamin Franzke rebased onto patch set 4 01/21/22, 09:27

  8. core-ci voted on patch set 4 V +1 01/21/22, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22339

  9. Mathias Brodala commented on patch set 4 01/21/22, 09:47

    Deprecation-96568-RequireJSModulesInFormFramework.rst:50

    This is a rather unusual path and will raise many questions. Maybe: > @my-vendor/my-site-package/Resources/Public/Backend/FormEditor/ViewModel.js
  10. Benjamin Franzke commented on patch set 4 01/21/22, 09:51

    Deprecation-96568-RequireJSModulesInFormFramework.rst:50 Reply

    true, that may be confusing without context. we should add the corresponding importmap configuration as in https://review.typo3.org/c/Packages/TYPO3.CMS/+/73026/4/typo3/sysext/form/Documentation/I/Concepts/FormEditor/Index.rst#181 here
  11. Mathias Brodala commented on patch set 4 01/21/22, 09:56

    Deprecation-96568-RequireJSModulesInFormFramework.rst:50 Reply

    Ack
  12. Benjamin Franzke uploaded patch set 5 01/21/22, 09:57

  13. Benjamin Franzke commented on patch set 5 01/21/22, 09:57

    Deprecation-96568-RequireJSModulesInFormFramework.rst:50 Reply

    Done
  14. Mathias Brodala commented on patch set 5 CR -1 01/21/22, 10:04

    Deprecation-96568-RequireJSModulesInFormFramework.rst:64

    This should use 4 space indentation (PSR-2), also "=" must be "=>". And we all love our little trailing comma. ;-) In any case this makes it way clearer, indeed.
  15. Benjamin Franzke uploaded patch set 6 01/21/22, 10:06

  16. Benjamin Franzke commented on patch set 6 01/21/22, 10:06

    Deprecation-96568-RequireJSModulesInFormFramework.rst:64 Reply

    oops, sorry, done.
  17. Benjamin Franzke uploaded patch set 7 01/21/22, 10:07

  18. core-ci voted on patch set 7 V +1 01/21/22, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22342

  19. Benni Mack voted on patch set 7 V +1 CR +1 01/21/22, 21:04

  20. Benjamin Franzke uploaded patch set 8 01/22/22, 19:50

    Resolve Merge Conflict
  21. core-ci voted on patch set 8 V +1 01/22/22, 20:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22411

  22. Benni Mack voted on patch set 8 V +1 CR +1 01/22/22, 20:46

  23. Oli Bartsch voted on patch set 8 V +1 CR +1 01/25/22, 10:29

  24. Benjamin Franzke voted on patch set 8 V +2 CR +2 01/25/22, 10:30

  25. Benjamin Franzke merged patch set 9 01/25/22, 10:30