73028[TASK] Avoid duplicate DragUploader initialization
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1317
-
Benjamin Franzke uploaded patch set 1 01/15/22, 00:48
-
core-ci voted on patch set 1 V +1 01/15/22, 01:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22106
-
Benjamin Franzke uploaded patch set 2 01/18/22, 07:41
-
Benjamin Franzke commented on patch set 2 01/18/22, 07:42
This change is ready for review. -
core-ci voted on patch set 2 V +1 01/18/22, 07:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22212
-
Benjamin Franzke commented on patch set 2 CR -1 01/18/22, 07:56
Hm, maybe we need to think about this one again. DragUploader.ts always calls initialize() by itself, wich means the initialize() method is then called twice by the inline control container: https://github.com/TYPO3/typo3/blob/ad87f3ed9f4fee41f21e51a1dd0e8c542ece58d4/Build/Sources/TypeScript/backend/Resources/Public/TypeScript/DragUploader.ts#L872 For that reason FileListController is able to simply require DragUploader without an invoke() statement: https://github.com/TYPO3/typo3/blob/ad87f3ed9f4fee41f21e51a1dd0e8c542ece58d4/typo3/sysext/filelist/Classes/Controller/FileListController.php#L447 Maybe we should just remove the "->invoke()" then? Question: Is it still worth to support this usecase in the JavaScriptItemProcessor? -
Benjamin Franzke uploaded patch set 3 01/21/22, 13:09
-
Benjamin Franzke commented on patch set 3 01/21/22, 13:20
This change is ready for review. -
Benjamin Franzke wrote 01/21/22, 13:20
Topic inline-javascript removed -
Benjamin Franzke wrote 01/21/22, 13:20
Topic set to esm -
core-ci voted on patch set 3 V +1 01/21/22, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22352
-
Benjamin Franzke updated the commit message in patch set 4 01/21/22, 13:38
-
core-ci voted on patch set 4 V +1 01/21/22, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22355
-
Andreas Kienast voted on patch set 4 V +1 CR +1 01/21/22, 14:17
-
Benni Mack voted on patch set 4 V +1 CR +1 01/21/22, 14:43
-
Benjamin Franzke voted on patch set 4 V +2 CR +2 01/21/22, 15:19
-
Benjamin Franzke merged patch set 5 01/21/22, 15:19