Review main Merged

73028[TASK] Avoid duplicate DragUploader initialization

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 01/21/22, 15:19

Commit message

The DragUploader module initializes itself by calling
initialize() as last execution step, therefore the
function does not need to be called a second time.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1317

  1. Benjamin Franzke uploaded patch set 1 01/15/22, 00:48

  2. core-ci voted on patch set 1 V +1 01/15/22, 01:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22106

  3. Benjamin Franzke uploaded patch set 2 01/18/22, 07:41

  4. Benjamin Franzke commented on patch set 2 01/18/22, 07:42

    This change is ready for review.
  5. core-ci voted on patch set 2 V +1 01/18/22, 07:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22212

  6. Benjamin Franzke commented on patch set 2 CR -1 01/18/22, 07:56

    Hm, maybe we need to think about this one again. DragUploader.ts always calls initialize() by itself, wich means the initialize() method is then called twice by the inline control container: https://github.com/TYPO3/typo3/blob/ad87f3ed9f4fee41f21e51a1dd0e8c542ece58d4/Build/Sources/TypeScript/backend/Resources/Public/TypeScript/DragUploader.ts#L872 For that reason FileListController is able to simply require DragUploader without an invoke() statement: https://github.com/TYPO3/typo3/blob/ad87f3ed9f4fee41f21e51a1dd0e8c542ece58d4/typo3/sysext/filelist/Classes/Controller/FileListController.php#L447 Maybe we should just remove the "->invoke()" then? Question: Is it still worth to support this usecase in the JavaScriptItemProcessor?
  7. Benjamin Franzke uploaded patch set 3 01/21/22, 13:09

  8. Benjamin Franzke commented on patch set 3 01/21/22, 13:20

    This change is ready for review.
  9. Benjamin Franzke wrote 01/21/22, 13:20

    Topic inline-javascript removed
  10. Benjamin Franzke wrote 01/21/22, 13:20

    Topic set to esm
  11. core-ci voted on patch set 3 V +1 01/21/22, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22352

  12. Benjamin Franzke updated the commit message in patch set 4 01/21/22, 13:38

  13. core-ci voted on patch set 4 V +1 01/21/22, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22355

  14. Andreas Kienast voted on patch set 4 V +1 CR +1 01/21/22, 14:17

  15. Benni Mack voted on patch set 4 V +1 CR +1 01/21/22, 14:43

  16. Benjamin Franzke voted on patch set 4 V +2 CR +2 01/21/22, 15:19

  17. Benjamin Franzke merged patch set 5 01/21/22, 15:19