73032[TASK] Use proper QueryBuilder execute() replacement methods
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 3
Files 196
- typo3/sysext/adminpanel/Classes/Repositories/FrontendGroupsRepository.php+2 −2
- typo3/sysext/backend/Classes/Authentication/PasswordReset.php+6 −6
- typo3/sysext/backend/Classes/Backend/Avatar/DefaultAvatarProvider.php+1 −1
- typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php+5 −5
- typo3/sysext/backend/Classes/Backend/ToolbarItems/UserToolbarItem.php+1 −1
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php+1 −1
- typo3/sysext/backend/Classes/Configuration/TranslationConfigurationProvider.php+1 −1
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+3 −3
- typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Page/SortSubPagesController.php+1 −1
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+5 −5
- typo3/sysext/backend/Classes/Controller/LoginController.php+1 −1
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+1 −1
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+5 −5
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+1 −1
- typo3/sysext/backend/Classes/Domain/Repository/Localization/LocalizationRepository.php+5 −5
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractDatabaseRecordProvider.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabasePageLanguageOverlayRows.php+1 −1
Show 176 more files
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInputPlaceholders.php+1 −1
- typo3/sysext/backend/Classes/Form/Wizard/SuggestWizardDefaultReceiver.php+2 −2
- typo3/sysext/backend/Classes/History/RecordHistory.php+3 −3
- typo3/sysext/backend/Classes/Search/LiveSearch/LiveSearch.php+1 −1
- typo3/sysext/backend/Classes/Security/CategoryPermissionsAspect.php+1 −1
- typo3/sysext/backend/Classes/Security/FailedLoginAttemptNotification.php+2 −2
- typo3/sysext/backend/Classes/Tree/Repository/PageTreeRepository.php+6 −6
- typo3/sysext/backend/Classes/Tree/View/AbstractContentPagePositionMap.php+1 −1
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php+2 −2
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+9 −9
- typo3/sysext/backend/Classes/View/BackendLayout/ContentFetcher.php+1 −1
- typo3/sysext/backend/Classes/View/BackendLayout/DefaultDataProvider.php+1 −1
- typo3/sysext/backend/Classes/View/BackendLayoutView.php+2 −2
- typo3/sysext/backend/Classes/View/PageLayoutContext.php+1 −1
- typo3/sysext/backend/Classes/View/PageLayoutView.php+4 −5
- typo3/sysext/backend/Classes/ViewHelpers/AvatarViewHelper.php+1 −1
- typo3/sysext/backend/Tests/Functional/History/RecordHistoryStoreTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php+7 −7
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectTreeItemsTest.php+1 −1
- typo3/sysext/belog/Classes/Controller/SystemInformationController.php+1 −1
- typo3/sysext/belog/Classes/Domain/Repository/LogEntryRepository.php+3 −3
- typo3/sysext/core/Classes/Authentication/AbstractAuthenticationService.php+1 −1
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+2 −2
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+7 −7
- typo3/sysext/core/Classes/Authentication/CommandLineUserAuthentication.php+1 −1
- typo3/sysext/core/Classes/Authentication/GroupResolver.php+3 −3
- typo3/sysext/core/Classes/Cache/Backend/Typo3DatabaseBackend.php+14 −14
- typo3/sysext/core/Classes/Category/Collection/CategoryCollection.php+2 −2
- typo3/sysext/core/Classes/Collection/AbstractRecordCollection.php+1 −1
- typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php+3 −3
- typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php+1 −1
- typo3/sysext/core/Classes/Database/Connection.php+2 −2
- typo3/sysext/core/Classes/Database/ReferenceIndex.php+14 −14
- typo3/sysext/core/Classes/Database/RelationHandler.php+10 −10
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php+2 −2
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+43 −43
- typo3/sysext/core/Classes/DataHandling/PlainDataResolver.php+4 −4
- typo3/sysext/core/Classes/DataHandling/ReferenceIndexUpdater.php+2 −2
- typo3/sysext/core/Classes/DataHandling/SlugHelper.php+3 −3
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+16 −16
- typo3/sysext/core/Classes/Resource/Collection/CategoryBasedFileCollection.php+1 −1
- typo3/sysext/core/Classes/Resource/Index/FileIndexRepository.php+8 −8
- typo3/sysext/core/Classes/Resource/Index/MetaDataRepository.php+1 −1
- typo3/sysext/core/Classes/Resource/Search/FileSearchQuery.php+5 −2
- typo3/sysext/core/Classes/Resource/AbstractRepository.php+2 −2
- typo3/sysext/core/Classes/Resource/FileCollectionRepository.php+2 −2
- typo3/sysext/core/Classes/Resource/FileRepository.php+1 −1
- typo3/sysext/core/Classes/Resource/ProcessedFileRepository.php+5 −5
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+2 −2
- typo3/sysext/core/Classes/Resource/StorageRepository.php+1 −1
- typo3/sysext/core/Classes/Resource/SynchronizeFolderRelations.php+4 −4
- typo3/sysext/core/Classes/Routing/Aspect/PersistedAliasMapper.php+2 −2
- typo3/sysext/core/Classes/Routing/Aspect/PersistedPatternMapper.php+2 −2
- typo3/sysext/core/Classes/Routing/PageSlugCandidateProvider.php+2 −2
- typo3/sysext/core/Classes/Session/Backend/DatabaseSessionBackend.php+5 −5
- typo3/sysext/core/Classes/Tree/TableConfiguration/DatabaseTreeDataProvider.php+3 −3
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+2 −2
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+2 −2
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php+3 −3
- typo3/sysext/core/Classes/Utility/RootlineUtility.php+3 −3
- typo3/sysext/core/Tests/Functional/Category/Collection/CategoryCollectionTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Database/Query/Expression/ExpressionBuilderTest.php+20 −20
- typo3/sysext/core/Tests/Functional/DataHandling/Flexform/ActionTest.php+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/FlexformIrre/ActionTest.php+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/AbstractDataHandlerActionTestCase.php+2 −2
- typo3/sysext/core/Tests/Unit/Configuration/FlexForm/FlexFormToolsTest.php+8 −8
- typo3/sysext/core/Tests/Unit/Database/Query/QueryBuilderTest.php+11 −11
- typo3/sysext/core/Tests/Unit/Resource/Repository/AbstractRepositoryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Tree/TableConfiguration/DatabaseTreeDataProviderTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/File/ExtendedFileUtilityTest.php+1 −1
- typo3/sysext/dashboard/Classes/Widgets/Provider/NumberOfFailedLoginsDataProvider.php+1 −1
- typo3/sysext/dashboard/Classes/Widgets/Provider/SysLogErrorsDataProvider.php+1 −1
- typo3/sysext/dashboard/Classes/Widgets/Provider/TypeOfUsersChartDataProvider.php+1 −1
- typo3/sysext/dashboard/Classes/DashboardRepository.php+6 −6
- typo3/sysext/extbase/Classes/Configuration/BackendConfigurationManager.php+3 −3
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php+5 −5
- typo3/sysext/extbase/Classes/Service/CacheService.php+1 −1
- typo3/sysext/extbase/Classes/Service/ExtensionService.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/AddTest.php+4 −4
- typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php+44 −44
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbBackendTest.php+1 −1
- typo3/sysext/extensionmanager/Classes/Domain/Repository/BulkExtensionRepositoryWriter.php+2 −2
- typo3/sysext/extensionmanager/Classes/Domain/Repository/ExtensionRepository.php+1 −1
- typo3/sysext/felogin/Classes/Domain/Repository/FrontendUserGroupRepository.php+1 −1
- typo3/sysext/felogin/Classes/Domain/Repository/FrontendUserRepository.php+7 −7
- typo3/sysext/felogin/Tests/Functional/Domain/Repository/FrontendUserRepositoryTest.php+2 −2
- typo3/sysext/filelist/Classes/FileList.php+2 −2
- typo3/sysext/form/Classes/Service/DatabaseService.php+2 −2
- typo3/sysext/frontend/Classes/Category/Collection/CategoryCollection.php+2 −2
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+4 −4
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+3 −3
- typo3/sysext/frontend/Classes/Hooks/TreelistCacheUpdateHooks.php+4 −4
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php+2 −2
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Authentication/FrontendUserAuthenticationTest.php+1 −1
- typo3/sysext/impexp/Classes/Domain/Repository/PresetRepository.php+2 −2
- typo3/sysext/impexp/Classes/Export.php+3 −3
- typo3/sysext/impexp/Classes/Import.php+1 −1
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImagesInFilledDatabaseTest.php+1 −1
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php+7 −7
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+3 −3
- typo3/sysext/indexed_search/Classes/Domain/Repository/AdministrationRepository.php+29 −23
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+13 −13
- typo3/sysext/indexed_search/Classes/Indexer.php+5 −5
- typo3/sysext/info/Classes/Controller/InfoPageTyposcriptConfigController.php+1 −1
- typo3/sysext/info/Classes/Controller/PageInformationController.php+4 −4
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+3 −3
- typo3/sysext/install/Classes/Controller/MaintenanceController.php+1 −1
- typo3/sysext/install/Classes/Controller/SettingsController.php+2 −2
- typo3/sysext/install/Classes/Controller/UpgradeController.php+2 −2
- typo3/sysext/install/Classes/Service/UpgradeWizardsService.php+1 −1
- typo3/sysext/install/Classes/SystemEnvironment/DatabaseCheck/Platform/MySql.php+1 −1
- typo3/sysext/install/Classes/Updates/RowUpdater/WorkspaceNewPlaceholderRemovalMigration.php+2 −2
- typo3/sysext/install/Classes/Updates/BackendUserLanguageMigration.php+2 −2
- typo3/sysext/install/Classes/Updates/CollectionsExtractionUpdate.php+1 −1
- typo3/sysext/install/Classes/Updates/DatabaseRowsUpdateWizard.php+1 −1
- typo3/sysext/install/Classes/Updates/ShortcutRecordsMigration.php+2 −2
- typo3/sysext/linkvalidator/Classes/Linktype/InternalLinktype.php+2 −2
- typo3/sysext/linkvalidator/Classes/Repository/BrokenLinkRepository.php+6 −6
- typo3/sysext/linkvalidator/Classes/Repository/PagesRepository.php+3 −3
- typo3/sysext/linkvalidator/Classes/Result/LinkAnalyzerResult.php+1 −1
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php+2 −2
- typo3/sysext/lowlevel/Classes/Command/CleanFlexFormsCommand.php+3 −3
- typo3/sysext/lowlevel/Classes/Command/DeletedRecordsCommand.php+9 −4
- typo3/sysext/lowlevel/Classes/Command/FilesWithMultipleReferencesCommand.php+1 −1
- typo3/sysext/lowlevel/Classes/Command/ListSysLogCommand.php+1 −1
- typo3/sysext/lowlevel/Classes/Command/LostFilesCommand.php+7 −2
- typo3/sysext/lowlevel/Classes/Command/MissingFilesCommand.php+2 −2
- typo3/sysext/lowlevel/Classes/Command/MissingRelationsCommand.php+2 −2
- typo3/sysext/lowlevel/Classes/Command/OrphanRecordsCommand.php+4 −4
- typo3/sysext/lowlevel/Classes/Database/QueryGenerator.php+11 −10
- typo3/sysext/lowlevel/Classes/Integrity/DatabaseIntegrityCheck.php+7 −7
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+1 −1
- typo3/sysext/recordlist/Classes/LinkHandler/PageLinkHandler.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+3 −3
- typo3/sysext/recordlist/Classes/RecordList/DownloadRecordList.php+1 −1
- typo3/sysext/recycler/Classes/Controller/RecyclerAjaxController.php+1 −1
- typo3/sysext/recycler/Classes/Domain/Model/DeletedRecords.php+4 −4
- typo3/sysext/recycler/Classes/Domain/Model/Tables.php+1 −1
- typo3/sysext/recycler/Classes/Task/CleanerTask.php+1 −1
- typo3/sysext/recycler/Classes/Utility/RecyclerUtility.php+3 −3
- typo3/sysext/redirects/Classes/EventListener/IncrementHitCount.php+1 −1
- typo3/sysext/redirects/Classes/Repository/RedirectRepository.php+5 −5
- typo3/sysext/redirects/Classes/Service/IntegrityService.php+2 −2
- typo3/sysext/redirects/Classes/Service/RedirectCacheService.php+1 −1
- typo3/sysext/redirects/Classes/Service/SlugService.php+2 −2
- typo3/sysext/redirects/Tests/Functional/Repository/RedirectRepositoryTest.php+1 −1
- typo3/sysext/reports/Classes/Report/Status/ConfigurationStatus.php+5 −5
- typo3/sysext/reports/Classes/Report/Status/FalStatus.php+3 −5
- typo3/sysext/reports/Classes/Report/Status/SecurityStatus.php+1 −1
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+2 −2
- typo3/sysext/scheduler/Classes/SystemInformation/ToolbarItemProvider.php+1 −1
- typo3/sysext/scheduler/Classes/Task/AbstractTask.php+3 −3
- typo3/sysext/scheduler/Classes/Task/IpAnonymizationTask.php+1 −1
- typo3/sysext/scheduler/Classes/Task/OptimizeDatabaseTableAdditionalFieldProvider.php+1 −1
- typo3/sysext/scheduler/Classes/Task/TableGarbageCollectionTask.php+1 −1
- typo3/sysext/scheduler/Classes/Scheduler.php+4 −4
- typo3/sysext/seo/Classes/XmlSitemap/PagesXmlSitemapDataProvider.php+1 −1
- typo3/sysext/seo/Classes/XmlSitemap/RecordsXmlSitemapDataProvider.php+1 −1
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+2 −2
- typo3/sysext/sys_note/Classes/Domain/Repository/SysNoteRepository.php+1 −1
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+1 −1
- typo3/sysext/workspaces/Classes/Authentication/PreviewUserAuthentication.php+1 −1
- typo3/sysext/workspaces/Classes/Command/AutoPublishCommand.php+2 −2
- typo3/sysext/workspaces/Classes/Command/CleanupPreviewLinksCommand.php+1 −1
- typo3/sysext/workspaces/Classes/Command/WorkspaceVersionRecordsCommand.php+5 −5
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php+1 −1
- typo3/sysext/workspaces/Classes/Dependency/ElementEntity.php+3 −3
- typo3/sysext/workspaces/Classes/Domain/Record/AbstractRecord.php+1 −1
- typo3/sysext/workspaces/Classes/Domain/Record/WorkspaceRecord.php+1 −1
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+7 −7
- typo3/sysext/workspaces/Classes/Middleware/WorkspacePreview.php+2 −2
- typo3/sysext/workspaces/Classes/Preview/PreviewUriBuilder.php+1 −1
- typo3/sysext/workspaces/Classes/Service/RecordService.php+1 −1
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+9 −9
Review log 1927
Show 12 earlier messages
-
Stefan Bürk uploaded patch set 1 01/15/22, 22:19
-
core-ci voted on patch set 1 V +1 01/15/22, 22:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22128
-
Stefan Bürk updated the commit message in patch set 2 01/15/22, 23:00
-
Stefan Bürk marked it ready for review 01/15/22, 23:01
-
core-ci voted on patch set 2 V +1 01/15/22, 23:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22129
-
Stefan Bürk commented on patch set 2 01/15/22, 23:16
Running nightly on it: https://git.typo3.org/typo3/CI/cms/-/pipelines/22130 -
core-ci voted on patch set 2 V -1 01/15/22, 23:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22130
-
core-ci voted on patch set 2 V +1 01/15/22, 23:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22130
-
Stefan Bürk wrote 01/16/22, 08:48
Topic set to doctrine/dbal -
Stefan Bürk uploaded patch set 3 01/16/22, 08:52
-
Stefan Bürk commented on patch set 3 01/16/22, 08:55
Backport is currently relative easily doable even if this is a cross-spread patch - which may change. - remove 1 file from cherry-pick (new event in main) - solve one simple/minor conflict in 1 file -
core-ci voted on patch set 3 V +1 01/16/22, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22137
-
Stefan Bürk rebased onto patch set 4 01/16/22, 21:44
-
core-ci voted on patch set 4 V +1 01/16/22, 21:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22157
-
Benni Mack updated the commit message in patch set 5 01/17/22, 07:24
-
core-ci voted on patch set 5 V +1 01/17/22, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22172
-
Benni Mack voted on patch set 5 V +1 CR +1 01/17/22, 08:48
-
Christian Kuhn voted on patch set 5 V +1 CR +1 01/17/22, 18:43
-
Benni Mack commented on patch set 5 01/18/22, 09:36
aaargh, now it has a merge conflcit. -
Stefan Bürk commented on patch set 5 01/18/22, 09:37
yes - merged impexp patch from lolli :/ Will rebase it in the lunch break .. backport "should" be still doable, but little bit more work. If backport is wanted I would do it then. Or should we drop the backport directly ? -
Christian Kuhn commented on patch set 5 01/18/22, 09:38
Reply
that was me in impexp PresetRepository. rather easy to solve, i guess stefan will take care soon. we should then reach a merge quickly to avoid further rebase hell for this one. -
Stefan Bürk uploaded patch set 6 01/18/22, 09:59
-
Christian Kuhn voted on patch set 6 V +1 CR +1 01/18/22, 10:11
-
Stefan Bürk commented on patch set 6 01/18/22, 10:12
Already prepared backport. Changes documented on backport -
core-ci voted on patch set 6 V +1 01/18/22, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22213
-
Benni Mack voted on patch set 6 V +2 CR +2 01/18/22, 12:43
-
Benni Mack merged patch set 7 01/18/22, 12:43