Review main Merged

73033[TASK] Refactor ext:impexp controller and view

Christian Kuhn CR +2 V +2 Nightmare +1173 −1537 updated 01/24/22, 16:52

Commit message

A bigger but careful refactoring of the
ImportController and ExportController together
with a view adaption. The module is still as
ugly as before, but the underlying codebase
should be much better understandable now.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 25

Show 5 more files

Review log 1729

Show 24 earlier messages
  1. Christian Kuhn uploaded patch set 1 01/16/22, 08:21

  2. Christian Kuhn updated the commit message in patch set 2 01/16/22, 08:22

  3. core-ci voted on patch set 1 V +1 01/16/22, 08:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22135

  4. core-ci voted on patch set 2 V +1 01/16/22, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22136

  1. Christian Kuhn uploaded patch set 3 01/16/22, 13:43

  2. Christian Kuhn uploaded patch set 4 01/16/22, 13:44

  3. core-ci voted on patch set 3 V -1 01/16/22, 13:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22139

  4. core-ci voted on patch set 4 V -1 01/16/22, 14:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22140

  5. Christian Kuhn uploaded patch set 5 01/16/22, 14:13

  6. core-ci voted on patch set 5 V -1 01/16/22, 14:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22141

  7. Christian Kuhn uploaded patch set 6 01/16/22, 18:25

  8. Christian Kuhn uploaded patch set 7 01/16/22, 18:25

  9. Christian Kuhn uploaded patch set 8 01/16/22, 18:40

  10. core-ci voted on patch set 7 V -1 01/16/22, 18:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22149

  11. core-ci voted on patch set 8 V -1 01/16/22, 18:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22150

  12. core-ci commented on patch set 8 01/17/22, 02:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22150

  13. Christian Kuhn uploaded patch set 9 01/17/22, 04:45

  14. core-ci voted on patch set 9 V -1 01/17/22, 05:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22169

  15. Christian Kuhn uploaded patch set 10 01/17/22, 06:51

  16. core-ci voted on patch set 10 V +1 01/17/22, 07:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22171

  17. Christian Kuhn uploaded patch set 11 01/17/22, 09:08

  18. core-ci voted on patch set 11 V +1 01/17/22, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22174

  19. Christian Kuhn updated the commit message in patch set 12 01/17/22, 09:28

  20. core-ci voted on patch set 12 V +1 01/17/22, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22175

  21. Stefan Bürk voted on patch set 12 V +1 CR +1 01/17/22, 20:53

  22. Benni Mack voted on patch set 12 V +2 CR +2 01/17/22, 21:11

  23. Benni Mack merged patch set 13 01/17/22, 21:11

  24. Oliver Hader commented on patch set 13 01/24/22, 16:24

    Save.html:144

    I guess double inference literals `{{ ... }}` are not intended to be used here, are they?
  25. Christian Kuhn commented on patch set 13 01/24/22, 16:52

    Save.html:144 Reply