73033[TASK] Refactor ext:impexp controller and view
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 25
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/AbstractCest.php+0 −71
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/ExportCest.php+0 −6
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/ImportCest.php+0 −8
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/UsersCest.php+70 −0
- typo3/sysext/impexp/Classes/Controller/ExportController.php+268 −329
- typo3/sysext/impexp/Classes/Controller/ImportController.php+154 −226
- typo3/sysext/impexp/Classes/Controller/ImportExportController.phpdeleted+0 −197
- typo3/sysext/impexp/Classes/Domain/Repository/PresetRepository.php+58 −106
- typo3/sysext/impexp/Classes/ViewHelpers/InArrayViewHelper.phpnew+39 −0
- typo3/sysext/impexp/Classes/ImportExport.php+0 −3
- typo3/sysext/impexp/Configuration/Backend/Routes.php+2 −2
- typo3/sysext/impexp/Resources/Private/Language/locallang.xlf+1 −4
- typo3/sysext/impexp/Resources/Private/Layouts/Default.htmldeleted+0 −11
- typo3/sysext/impexp/Resources/Private/Partials/Export/AdvancedOptions.html+43 −17
- typo3/sysext/impexp/Resources/Private/Partials/Export/Configuration.html+96 −44
- typo3/sysext/impexp/Resources/Private/Partials/Export/Save.html2+127 −51
- typo3/sysext/impexp/Resources/Private/Partials/Import/Import.html+115 −50
- typo3/sysext/impexp/Resources/Private/Partials/Import/MetaData.html+40 −38
- typo3/sysext/impexp/Resources/Private/Partials/Import/Upload.html+26 −14
- typo3/sysext/impexp/Resources/Private/Partials/Preview.html+22 −20
Show 5 more files
- typo3/sysext/impexp/Resources/Private/Templates/ImportExport/Export.htmldeleted+0 −81
- typo3/sysext/impexp/Resources/Private/Templates/Export.htmlnew+87 −0
- typo3/sysext/impexp/Resources/Private/Templates/Import.htmlrenamed+25 −19
- typo3/sysext/impexp/Tests/Functional/Export/ExportControllerTest.phpdeleted+0 −122
- typo3/sysext/impexp/Tests/Functional/Export/PresetsTest.phpdeleted+0 −118
Review log 1729
Show 24 earlier messages
-
Christian Kuhn uploaded patch set 1 01/16/22, 08:21
-
Christian Kuhn updated the commit message in patch set 2 01/16/22, 08:22
-
core-ci voted on patch set 1 V +1 01/16/22, 08:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22135
-
core-ci voted on patch set 2 V +1 01/16/22, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22136
-
Christian Kuhn uploaded patch set 3 01/16/22, 13:43
-
Christian Kuhn uploaded patch set 4 01/16/22, 13:44
-
core-ci voted on patch set 3 V -1 01/16/22, 13:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22139
-
core-ci voted on patch set 4 V -1 01/16/22, 14:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22140
-
Christian Kuhn uploaded patch set 5 01/16/22, 14:13
-
core-ci voted on patch set 5 V -1 01/16/22, 14:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22141
-
Christian Kuhn uploaded patch set 6 01/16/22, 18:25
-
Christian Kuhn uploaded patch set 7 01/16/22, 18:25
-
Christian Kuhn uploaded patch set 8 01/16/22, 18:40
-
core-ci voted on patch set 7 V -1 01/16/22, 18:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22149
-
core-ci voted on patch set 8 V -1 01/16/22, 18:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22150
-
core-ci commented on patch set 8 01/17/22, 02:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22150
-
Christian Kuhn uploaded patch set 9 01/17/22, 04:45
-
core-ci voted on patch set 9 V -1 01/17/22, 05:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22169
-
Christian Kuhn uploaded patch set 10 01/17/22, 06:51
-
core-ci voted on patch set 10 V +1 01/17/22, 07:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22171
-
Christian Kuhn uploaded patch set 11 01/17/22, 09:08
-
core-ci voted on patch set 11 V +1 01/17/22, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22174
-
Christian Kuhn updated the commit message in patch set 12 01/17/22, 09:28
-
core-ci voted on patch set 12 V +1 01/17/22, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22175
-
Stefan Bürk voted on patch set 12 V +1 CR +1 01/17/22, 20:53
-
Benni Mack voted on patch set 12 V +2 CR +2 01/17/22, 21:11
-
Benni Mack merged patch set 13 01/17/22, 21:11
-
Oliver Hader commented on patch set 13 01/24/22, 16:24
-
Christian Kuhn commented on patch set 13 01/24/22, 16:52
Save.html:144Replygood catch. my bad. thx! https://review.typo3.org/c/Packages/TYPO3.CMS/+/73139
Save.html:144