73035[!!!][TASK] Prepare for new minimum system requirements
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 18
- Build/gitlab-ci/nightly/acceptance-application.yml+104 −102
- Build/gitlab-ci/nightly/acceptance-install.yml+4 −364
- Build/gitlab-ci/nightly/functional.yml+72 −142
- Build/gitlab-ci/nightly/integrity.yml+21 −49
- Build/gitlab-ci/nightly/unit.yml+1 −199
- Build/gitlab-ci/pre-merge/acceptance-application.yml2+0 −16
- Build/gitlab-ci/pre-merge/acceptance-install.yml+7 −7
- Build/gitlab-ci/pre-merge/early.yml+3 −3
- Build/gitlab-ci/pre-merge/functional.yml+9 −9
- Build/gitlab-ci/pre-merge/integrity.yml+18 −33
- Build/gitlab-ci/pre-merge/unit.yml+1 −29
- Build/Scripts/runTests.sh+21 −55
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96553-TYPO3V12SystemRequirements.rstnew+45 −0
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/UpgradeCest.php+0 −21
- typo3/sysext/core/composer.json+1 −1
- typo3/sysext/install/Classes/Controller/UpgradeController.php+4 −0
- composer.json+2 −2
- composer.lock+3 −3
Review log 2544
Show 819 earlier messages
-
Stefan Bürk uploaded patch set 1 01/16/22, 15:21
-
Stefan Bürk updated the commit message in patch set 2 01/16/22, 15:23
-
Stefan Bürk updated the commit message in patch set 3 01/16/22, 15:27
-
core-ci voted on patch set 2 V -1 01/16/22, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22143
-
core-ci voted on patch set 3 V -1 01/16/22, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22144
-
core-ci voted on patch set 1 V -1 01/16/22, 15:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22142
-
core-ci commented on patch set 3 01/16/22, 15:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22144
-
Stefan Bürk uploaded patch set 4 01/16/22, 17:29
-
Stefan Bürk updated the commit message in patch set 5 01/16/22, 17:35
-
core-ci voted on patch set 4 V +1 01/16/22, 17:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22145
-
core-ci voted on patch set 5 V +1 01/16/22, 17:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22146
-
Stefan Bürk commented on patch set 5 01/16/22, 18:00
Running nightly on it to test changed nightly configuration: https://git.typo3.org/typo3/CI/cms/-/pipelines/22147 -
core-ci voted on patch set 5 V -1 01/16/22, 18:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22147
-
Stefan Bürk uploaded patch set 6 01/16/22, 19:10
-
core-ci voted on patch set 6 V +1 01/16/22, 19:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22151
-
core-ci voted on patch set 6 V -1 01/16/22, 20:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22152
-
core-ci commented on patch set 6 01/16/22, 20:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22152
-
Stefan Bürk uploaded patch set 7 01/16/22, 20:19
-
core-ci voted on patch set 7 V +1 01/16/22, 20:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22154
-
Stefan Bürk commented on patch set 7 01/16/22, 21:04
Nightly for patchset 7: https://git.typo3.org/typo3/CI/cms/-/pipelines/22156 -
core-ci voted on patch set 7 V -1 01/16/22, 21:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22156
-
core-ci voted on patch set 7 V +1 01/16/22, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22156
-
Christian Kuhn commented on patch set 7 01/17/22, 03:41
acceptance-application.yml:17i'd prefer to have only one set of ac tests for pre-merge: the benefit of running both php-8.1-maria plus php-8.1-mysql is negligible, basically just doubles the amount of false positives and takes quite some time. let's go with just mysql 8.1 and have a let check nightly if pre-merge missed something. -
Christian Kuhn uploaded patch set 8 01/17/22, 03:53
-
Christian Kuhn updated the commit message in patch set 9 01/17/22, 03:56
-
Christian Kuhn commented on patch set 9 01/17/22, 03:57
acceptance-application.yml:17ReplyDone -
core-ci voted on patch set 8 V +1 01/17/22, 04:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22166
-
core-ci voted on patch set 9 V -1 01/17/22, 04:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22167
-
core-ci commented on patch set 9 01/17/22, 04:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22167
-
Christian Kuhn commented on patch set 9 CR -1 01/17/22, 04:22
I guess we should add a .rst outlining the PHP and DBMS changes? -
core-ci voted on patch set 9 V +1 01/17/22, 04:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22167
-
Stefan Bürk commented on patch set 9 01/17/22, 09:14
Reply
That came to my mind in the small nap tonight also. Ack. -
Christian Kuhn uploaded patch set 10 01/17/22, 21:48
-
Christian Kuhn uploaded patch set 11 01/17/22, 21:51
-
core-ci voted on patch set 10 V +1 01/17/22, 21:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22201
-
core-ci voted on patch set 11 V +1 01/17/22, 22:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22202
-
Christian Kuhn commented on patch set 11 V +1 CR +1 01/17/22, 22:07
Fine with me. I guess this one should have a sign-off by Benni, though. -
Stefan Bürk commented on patch set 11 01/18/22, 07:53
Thx for the rst file, and the change as talked. Fine with me, and also fine with waiting for Benni's sign-off. -
Stefan Bürk voted on patch set 11 V +1 CR +1 01/18/22, 07:53
-
Benni Mack commented on patch set 11 01/18/22, 09:16
@christian should we also include the required PHP extensions? Especially since PHP 8.1 deprecates a lot of locale-related parts, I think we should include php-intl (and adapt our news accordingly) -
Stefan Bürk commented on patch set 11 01/18/22, 09:31
Reply
Should we make a round which is really needed ? Maybe having mbstring as direct requirement would be also nice. And the we should add/adjust the required exts in the jsons. -
Christian Kuhn commented on patch set 11 01/18/22, 09:35
Reply
Yeah. That came to my mind as well. Looking through composer.json, these are candidates we may want to discuss: gd, finfo, zlib, intl, mbstring ... others? 'intl' is important to have since it's the only way to fix all our locale + sorting issues and the symfony polyfills are only very basic implementations of 'en' only. gd could be good for general image manipulation (cropper & friends) - we may finally want to add this. unsure here. finfo for fal, maybe even exif? zlib for compression stuff? mbstring since the symfony polyfill is still a bit incomplete and mbstring is so common meanwhile that it really shouldn't hurt. -
Benni Mack commented on patch set 11 V +2 CR +2 01/18/22, 12:44
Reply
let's handle php extensions separately -
Benni Mack merged patch set 12 01/18/22, 12:45