Review main Merged Breaking

73035[!!!][TASK] Prepare for new minimum system requirements

Stefan Bürk CR +2 V +2 Expert +316 −1035 updated 01/18/22, 12:45

Commit message

System Requirements have been announced for TYPO3
v12 [1]: PHP 8.1 and higher, raised minimum DBMS
versions and removed mssql support.

The patch sets according PHP requirements in
the central composer.json files:

> composer config platform.php 8.1.1
> composer req php:"^8.1"
> composer req php:"^8.1" -d typo3/sysext/core --no-update

The patch adjusts the core main test suite to run
tests with PHP 8.1, ignoring older PHP releases,
drops mssql from the test suites and raises versions
of other DBMS in the test suite.

The option set of Build/Scripts/runTests.sh is
updated accordingly. phpstan needs a special
handling since it is not PHP 8.1 ready, yet: The
code scanner is still run using PHP 8.0 for now.

With the default charset being changed to utf8
in mysql, an acceptance tests becomes obsolete and
is substituted with an @todo comment to further
investigate if we could streamline the underlying
code in the install tool.

[1] https://typo3.org/article/new-system-requirements-for-upcoming-typo3-v12

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 2544

Show 819 earlier messages
  1. Stefan Bürk uploaded patch set 1 01/16/22, 15:21

  2. Stefan Bürk updated the commit message in patch set 2 01/16/22, 15:23

  3. Stefan Bürk updated the commit message in patch set 3 01/16/22, 15:27

  4. core-ci voted on patch set 2 V -1 01/16/22, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22143

  5. core-ci voted on patch set 3 V -1 01/16/22, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22144

  6. core-ci voted on patch set 1 V -1 01/16/22, 15:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22142

  7. core-ci commented on patch set 3 01/16/22, 15:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22144

  8. Stefan Bürk uploaded patch set 4 01/16/22, 17:29

  9. Stefan Bürk updated the commit message in patch set 5 01/16/22, 17:35

  10. core-ci voted on patch set 4 V +1 01/16/22, 17:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22145

  11. core-ci voted on patch set 5 V +1 01/16/22, 17:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22146

  12. Stefan Bürk commented on patch set 5 01/16/22, 18:00

    Running nightly on it to test changed nightly configuration: https://git.typo3.org/typo3/CI/cms/-/pipelines/22147
  13. core-ci voted on patch set 5 V -1 01/16/22, 18:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22147

  14. Stefan Bürk uploaded patch set 6 01/16/22, 19:10

  15. core-ci voted on patch set 6 V +1 01/16/22, 19:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22151

  16. core-ci voted on patch set 6 V -1 01/16/22, 20:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22152

  17. core-ci commented on patch set 6 01/16/22, 20:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22152

  18. Stefan Bürk uploaded patch set 7 01/16/22, 20:19

  19. core-ci voted on patch set 7 V +1 01/16/22, 20:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22154

  1. Stefan Bürk commented on patch set 7 01/16/22, 21:04

  2. core-ci voted on patch set 7 V -1 01/16/22, 21:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22156

  3. core-ci voted on patch set 7 V +1 01/16/22, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22156

  4. Christian Kuhn commented on patch set 7 01/17/22, 03:41

    acceptance-application.yml:17

    i'd prefer to have only one set of ac tests for pre-merge: the benefit of running both php-8.1-maria plus php-8.1-mysql is negligible, basically just doubles the amount of false positives and takes quite some time. let's go with just mysql 8.1 and have a let check nightly if pre-merge missed something.
  5. Christian Kuhn uploaded patch set 8 01/17/22, 03:53

  6. Christian Kuhn updated the commit message in patch set 9 01/17/22, 03:56

  7. Christian Kuhn commented on patch set 9 01/17/22, 03:57

    acceptance-application.yml:17 Reply

    Done
  8. core-ci voted on patch set 8 V +1 01/17/22, 04:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22166

  9. core-ci voted on patch set 9 V -1 01/17/22, 04:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22167

  10. core-ci commented on patch set 9 01/17/22, 04:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22167

  11. Christian Kuhn commented on patch set 9 CR -1 01/17/22, 04:22

    I guess we should add a .rst outlining the PHP and DBMS changes?
  12. core-ci voted on patch set 9 V +1 01/17/22, 04:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22167

  13. Stefan Bürk commented on patch set 9 01/17/22, 09:14

    Reply

    That came to my mind in the small nap tonight also. Ack.
  14. Christian Kuhn uploaded patch set 10 01/17/22, 21:48

  15. Christian Kuhn uploaded patch set 11 01/17/22, 21:51

  16. core-ci voted on patch set 10 V +1 01/17/22, 21:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22201

  17. core-ci voted on patch set 11 V +1 01/17/22, 22:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22202

  18. Christian Kuhn commented on patch set 11 V +1 CR +1 01/17/22, 22:07

    Fine with me. I guess this one should have a sign-off by Benni, though.
  19. Stefan Bürk commented on patch set 11 01/18/22, 07:53

    Thx for the rst file, and the change as talked. Fine with me, and also fine with waiting for Benni's sign-off.
  20. Stefan Bürk voted on patch set 11 V +1 CR +1 01/18/22, 07:53

  21. Benni Mack commented on patch set 11 01/18/22, 09:16

    @christian should we also include the required PHP extensions? Especially since PHP 8.1 deprecates a lot of locale-related parts, I think we should include php-intl (and adapt our news accordingly)
  22. Stefan Bürk commented on patch set 11 01/18/22, 09:31

    Reply

    Should we make a round which is really needed ? Maybe having mbstring as direct requirement would be also nice. And the we should add/adjust the required exts in the jsons.
  23. Christian Kuhn commented on patch set 11 01/18/22, 09:35

    Reply

    Yeah. That came to my mind as well. Looking through composer.json, these are candidates we may want to discuss: gd, finfo, zlib, intl, mbstring ... others? 'intl' is important to have since it's the only way to fix all our locale + sorting issues and the symfony polyfills are only very basic implementations of 'en' only. gd could be good for general image manipulation (cropper & friends) - we may finally want to add this. unsure here. finfo for fal, maybe even exif? zlib for compression stuff? mbstring since the symfony polyfill is still a bit incomplete and mbstring is so common meanwhile that it really shouldn't hurt.
  24. Benni Mack commented on patch set 11 V +2 CR +2 01/18/22, 12:44

    Reply

    let's handle php extensions separately
  25. Benni Mack merged patch set 12 01/18/22, 12:45