73037[TASK] Revamp phpstan config and handling
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Daniel Goerz +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Daniel Goerz +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 22
- Build/gitlab-ci/nightly/integrity.yml+1 −2
- Build/gitlab-ci/pre-merge/integrity.yml+1 −2
- Build/phpstan/phpstan-baseline.neonnew+10082 −0
- Build/phpstan/phpstan-constants.phpnew+4 −0
- Build/phpstan/phpstan.neonnew+27 −0
- Build/Scripts/runTests.sh+7 −2
- Build/testing-docker/local/docker-compose.yml+16 −1
- Build/phpstan.level3.neondeleted+0 −100
- Build/phpstan.level4.neondeleted+0 −188
- Build/phpstan.level5.neondeleted+0 −20
- Build/phpstan.level6.neondeleted+0 −16
- Build/phpstan.level7.neondeleted+0 −6
- Build/phpstan.level8.neondeleted+0 −5
- Build/phpstan.php8config.phpdeleted+0 −68
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler/Classes/Tca/SelectElementItems.php+1 −3
- typo3/sysext/core/Tests/Unit/Database/Mocks/MockPlatform.php+5 −20
- typo3/sysext/core/Tests/Unit/Mail/Fixtures/FakeValidSpoolFixture.php+2 −1
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchemaTest.php+1 −0
- typo3/sysext/install/Classes/Updates/PrerequisiteCollection.php+1 −4
- composer.json+2 −2
Show 2 more files
Review log 2030
Show 35 earlier messages
-
Stefan Bürk uploaded patch set 1 01/16/22, 20:54
-
core-ci voted on patch set 1 V -1 01/16/22, 21:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22155
-
Stefan Bürk uploaded patch set 2 01/17/22, 08:44
-
Stefan Bürk commented on patch set 2 01/17/22, 08:53
changed from fork to release of friendsoftypo3/phpstan-typo3 with phpstan 1.2.0 compatibility -
core-ci voted on patch set 2 V -1 01/17/22, 09:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22173
-
Stefan Bürk uploaded patch set 3 01/19/22, 13:04
-
core-ci voted on patch set 3 V -1 01/19/22, 13:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22265
-
Stefan Bürk rebased onto patch set 4 01/19/22, 14:29
-
core-ci voted on patch set 4 V -1 01/19/22, 14:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22270
-
Stefan Bürk uploaded patch set 5 01/29/22, 12:59
-
core-ci voted on patch set 5 V -1 01/29/22, 13:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22655
-
Stefan Bürk uploaded patch set 6 01/29/22, 13:24
-
Stefan Bürk uploaded patch set 7 01/29/22, 13:31
-
core-ci voted on patch set 6 V -1 01/29/22, 13:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22656
-
core-ci voted on patch set 7 V -1 01/29/22, 13:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22657
-
Christian Kuhn uploaded patch set 8 01/29/22, 16:21
-
core-ci voted on patch set 8 V +1 01/29/22, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22658
-
Christian Kuhn uploaded patch set 9 01/29/22, 16:58
-
Christian Kuhn updated the commit message in patch set 10 01/29/22, 16:58
-
Stefan Bürk voted on patch set 10 CR +1 01/29/22, 17:01
-
Christian Kuhn uploaded patch set 11 01/29/22, 17:09
-
core-ci voted on patch set 10 V +1 01/29/22, 17:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22662
-
core-ci voted on patch set 11 V +1 01/29/22, 17:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22664
-
Stefan Bürk voted on patch set 11 CR +1 01/29/22, 17:23
-
Christian Kuhn voted on patch set 11 V +1 CR +1 01/29/22, 17:24
-
Daniel Goerz commented on patch set 11 V +1 CR +1 01/29/22, 17:33
The initial idea of the config was to have as many rules active as possible while working on fulfilling whole levels. This is bad for maintainability, so I support the approach to introduce a baseline. I would, however, go for a higher level then, because the baseline enables us to go to moon and grab for the stars ... 😊 Don't take that too serious, I am fine with level 3 as well. If we increase the level later, that's also good. Thanks for picking up the loose ends <3 -
Christian Kuhn commented on patch set 11 01/29/22, 17:34
Reply
i'm pretty sure we can raise to level 5 relatively soon - stefan and me will push a couple of dedicated patches to reduce current baseline, then we'll quickly raise to level 5. -
Stefan Bürk voted on patch set 11 V +1 01/29/22, 17:34
-
Christian Kuhn voted on patch set 11 V +2 CR +2 01/29/22, 18:45
-
Christian Kuhn merged patch set 12 01/29/22, 18:46