Review main Merged

73039[TASK] runTests.sh: Skip reports.xml in acceptance tests

Christian Kuhn CR +2 V +2 Easy +16 −16 updated 01/17/22, 21:54

Commit message

The created reports.xml when running acceptance tests
is used for nothing in CI and just uploaded as artifact
along with the other reports. When ac tests fail, the
generally useful file is reports.html together with the
screenshots. Creating the xml file is skipped now.

Users who still want to create the xml file when running
the acceptanc test suite can do so by adding the "extra"
argument to runTests.sh:
> Build/Scripts/runTests.sh -s acceptance -e '--xml reports.xml'

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 01/17/22, 04:57

  2. core-ci voted on patch set 1 V +1 01/17/22, 05:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22170

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 01/17/22, 08:17

  4. Benni Mack voted on patch set 1 V +1 CR +1 01/17/22, 08:28

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 01/17/22, 21:54

  6. Christian Kuhn merged patch set 2 01/17/22, 21:54