Review main Merged

73040[BUGFIX] Replace properties correctly in Extbase Persistence Class overrides

Benni Mack CR +2 V +2 Easy +7 −8 updated 01/22/22, 12:00

Commit message

Due to a bug, the class properties did not override
properly using alternative names as the TYPO3-internal
"mergeRecursiveWithOverrule" was used in the wrong order.

This patch now uses "array_replace_recursive" and adds the
child properties at the very end.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1317

  1. Benni Mack uploaded patch set 1 01/17/22, 09:47

  2. core-ci voted on patch set 1 V -1 01/17/22, 10:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22176

  3. Claus Harup voted on patch set 1 CR +1 01/17/22, 10:19

  4. Robin Louis van Komen voted on patch set 1 CR +1 01/19/22, 10:02

  5. Benni Mack uploaded patch set 2 01/21/22, 23:33

  6. core-ci voted on patch set 2 V +1 01/22/22, 00:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22388

  7. Stefan Bürk updated the commit message in patch set 3 01/22/22, 00:05

  8. Stefan Bürk voted on patch set 3 V +1 CR +1 01/22/22, 00:16

  9. core-ci voted on patch set 3 V +1 01/22/22, 00:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22391

  10. Christian Kuhn commented on patch set 4 01/22/22, 08:05

    Published edit on patch set 3.
  11. Christian Kuhn voted on patch set 4 V +1 CR +1 01/22/22, 08:05

  12. core-ci voted on patch set 4 V +1 01/22/22, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22399

  13. Stefan Bürk voted on patch set 4 V +1 CR +1 01/22/22, 08:34

  14. Oli Bartsch voted on patch set 4 V +1 01/22/22, 11:07

  15. Oli Bartsch voted on patch set 4 CR +1 01/22/22, 11:07

  16. Benni Mack voted on patch set 4 V +2 CR +2 01/22/22, 12:00

  17. Benni Mack merged patch set 5 01/22/22, 12:00