Review main Merged

73041[FEATURE] Add centralized way to load PageTsConfig

Benni Mack CR +2 V +2 Hard +264 −232 updated 01/21/22, 21:33

Commit message

This change adds a new way to load globally defined
PageTsConfig which was previously handled
via "ExtensionManagementUtility::addPageTSConfig"
and "TYPO3_CONF_VARS[SYS][defaultPageTSconfig]".

This change now checks all extensions for
Configuration/page.tsconfig files and
caches the contents of the files in the Core Cache.

Benefits:
* The contents of these files are now cached in core.cache
* No explicit configuration of such files anymore
* Smaller TYPO3_CONF_VARS footprint
* Loading of files reduces file i/o for each request when accessing PageTS
* Autowiring from DI Service Provider possible

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 29

Show 9 more files

Review log 2838

Show 913 earlier messages
  1. Benni Mack uploaded patch set 1 01/17/22, 10:05

  2. core-ci voted on patch set 1 V -1 01/17/22, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22177

  3. Benni Mack uploaded patch set 2 01/17/22, 10:32

  4. core-ci voted on patch set 2 V -1 01/17/22, 10:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22179

  5. Benni Mack uploaded patch set 3 01/17/22, 12:26

  6. core-ci voted on patch set 3 V -1 01/17/22, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22181

  7. core-ci voted on patch set 3 V +1 01/17/22, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22181

  8. Oli Bartsch commented on patch set 3 01/17/22, 15:18

    Could we

    AbstractServiceProvider.php:113

    I think this path will be really hard to memorize. Could we may shorten this somehow to e.g. "Configuration/Page.tsconfig"? This would be similar to existing files like "RequestMiddlewares.php" and "Icons.php".
  9. Benni Mack commented on patch set 3 01/18/22, 08:06

    AbstractServiceProvider.php:113 Reply

    I like this too. The initial idea was based on the current standardized folder names, which are much too complicated. Any other opinions here?
  10. Benjamin Franzke commented on patch set 3 01/18/22, 08:41

    AbstractServiceProvider.php:113 Reply

    +1 for Configuration/Page.tsconfig
  11. Benni Mack uploaded patch set 4 01/19/22, 10:53

  12. Benni Mack commented on patch set 5 01/19/22, 10:54

    Published edit on patch set 4.
  13. Benni Mack commented on patch set 5 01/19/22, 10:56

    AbstractServiceProvider.php:113 Reply

    Hmm, I now use page.tsconfig, regarding lower/uppercase we can still "decide" :)
  1. core-ci voted on patch set 4 V +1 01/19/22, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22254

  2. core-ci voted on patch set 5 V +1 01/19/22, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22255

  3. Christian Kuhn commented on patch set 5 01/19/22, 11:12

    AbstractServiceProvider.php:113 Reply

    Will we have the same for user.tsconfig (to substitute conf-vars 'defaultUserTSconfig'?) Regarding casing: ... maybe we should simply accept *both* Page.tsconfig and page.tsconfig ... it's kinda hard to memorize casing details and existing files in Configuration/ tend to be UpperCamelCase ...
  4. Christian Kuhn commented on patch set 5 01/19/22, 11:26

    page.tsconfig:1

    inline this, too?

    page.tsconfig:1

    ext:recordlist uses this in sysext/recordlist/Classes/Controller/RecordListController.php and sysext/recordlist/Classes/Browser/DatabaseBrowser.php I guess this section should be moved to ext:recordlist
  5. Benni Mack commented on patch set 5 01/19/22, 13:23

    page.tsconfig:1 Reply

    will do

    page.tsconfig:1 Reply

    yes.
  6. Benni Mack uploaded patch set 6 01/21/22, 20:34

  7. Benni Mack uploaded patch set 7 01/21/22, 20:36

  8. Benni Mack commented on patch set 6 01/21/22, 20:36

    AbstractServiceProvider.php:113 Reply

    user.tsconfig will come at a later point

    page.tsconfig:1 Reply

    Done

    page.tsconfig:1 Reply

    Done
  9. Benni Mack commented on patch set 7 01/21/22, 20:36

    AbstractServiceProvider.php:113 Reply

    Done
  10. core-ci voted on patch set 6 V +1 01/21/22, 20:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22374

  11. core-ci voted on patch set 7 V +1 01/21/22, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22375

  12. Benjamin Franzke commented on patch set 7 CR +1 01/21/22, 20:51

    Feature-96614-AutomaticInclusionOfPageTsConfigOfExtensions.rst:15

    typo
  13. Benni Mack commented on patch set 8 01/21/22, 20:54

    Published edit on patch set 7.
  14. Benni Mack commented on patch set 8 01/21/22, 20:54

    Feature-96614-AutomaticInclusionOfPageTsConfigOfExtensions.rst:15 Reply

    Done
  15. Christian Kuhn voted on patch set 8 V +1 CR +1 01/21/22, 21:01

  16. Oli Bartsch voted on patch set 8 V +1 CR +1 01/21/22, 21:02

  17. core-ci voted on patch set 8 V +1 01/21/22, 21:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22376

  18. Benjamin Franzke uploaded patch set 9 01/21/22, 21:14

  19. Benjamin Franzke commented on patch set 9 01/21/22, 21:15

    ServiceProvider.php:340

    We need to var_export/require here as $cache->get delivers "<?php" prefix otherwise. Pushed patchset 9 to do so.
  20. Christian Kuhn commented on patch set 9 CR -1 01/21/22, 21:23

    debugging a bit. temp -1, but will most likely upvote soon.
  21. Christian Kuhn voted on patch set 9 V +1 CR +1 01/21/22, 21:30

  22. Stefan Bürk voted on patch set 9 V +1 CR +1 01/21/22, 21:30

  23. core-ci voted on patch set 9 V +1 01/21/22, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22377

  24. Benni Mack voted on patch set 9 V +2 CR +2 01/21/22, 21:33

  25. Benni Mack merged patch set 10 01/21/22, 21:33