73041[FEATURE] Add centralized way to load PageTsConfig
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 29
- typo3/sysext/backend/Configuration/page.tsconfigrenamed+3 −0
- typo3/sysext/backend/ext_localconf.php+0 −6
- typo3/sysext/core/Classes/Configuration/Loader/PageTsConfigLoader.php+11 −1
- typo3/sysext/core/Classes/Package/AbstractServiceProvider.php7+18 −0
- typo3/sysext/core/Classes/ServiceProvider.php1+25 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −106
- typo3/sysext/core/Configuration/page.tsconfignew+1 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-96614-AutomaticInclusionOfPageTsConfigOfExtensions.rst2new+30 −0
- typo3/sysext/core/ext_localconf.php+0 −5
- typo3/sysext/felogin/Configuration/page.tsconfigrenamed+0 −0
- typo3/sysext/felogin/ext_localconf.php+0 −5
- typo3/sysext/form/Configuration/page.tsconfigrenamed+0 −0
- typo3/sysext/form/ext_localconf.php+0 −5
- typo3/sysext/frontend/Configuration/TsConfig/Page/TCEFORM.tsconfigdeleted+0 −9
- typo3/sysext/frontend/Configuration/page.tsconfig3renamed+10 −0
- typo3/sysext/frontend/ext_localconf.php+0 −9
- typo3/sysext/indexed_search/Configuration/page.tsconfignew+13 −0
- typo3/sysext/indexed_search/ext_localconf.php+0 −17
- typo3/sysext/info/Configuration/page.tsconfig3new+18 −0
- typo3/sysext/linkvalidator/Configuration/page.tsconfigrenamed+0 −0
Show 9 more files
- typo3/sysext/linkvalidator/Documentation/Configuration/Index.rst+1 −1
- typo3/sysext/linkvalidator/ext_localconf.php+0 −5
- typo3/sysext/recordlist/Configuration/page.tsconfignew+58 −0
- typo3/sysext/recordlist/ext_localconf.php+0 −41
- typo3/sysext/seo/Configuration/page.tsconfignew+10 −0
- typo3/sysext/seo/ext_localconf.php+0 −13
- typo3/sysext/viewpage/Configuration/page.tsconfignew+61 −0
- typo3/sysext/workspaces/Configuration/page.tsconfignew+4 −0
- typo3/sysext/workspaces/ext_localconf.php+0 −9
Review log 2838
Show 913 earlier messages
-
Benni Mack uploaded patch set 1 01/17/22, 10:05
-
core-ci voted on patch set 1 V -1 01/17/22, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22177
-
Benni Mack uploaded patch set 2 01/17/22, 10:32
-
core-ci voted on patch set 2 V -1 01/17/22, 10:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22179
-
Benni Mack uploaded patch set 3 01/17/22, 12:26
-
core-ci voted on patch set 3 V -1 01/17/22, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22181
-
core-ci voted on patch set 3 V +1 01/17/22, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22181
-
Oli Bartsch commented on patch set 3 01/17/22, 15:18
Could weAbstractServiceProvider.php:113I think this path will be really hard to memorize. Could we may shorten this somehow to e.g. "Configuration/Page.tsconfig"? This would be similar to existing files like "RequestMiddlewares.php" and "Icons.php". -
Benni Mack commented on patch set 3 01/18/22, 08:06
AbstractServiceProvider.php:113ReplyI like this too. The initial idea was based on the current standardized folder names, which are much too complicated. Any other opinions here? -
Benjamin Franzke commented on patch set 3 01/18/22, 08:41
AbstractServiceProvider.php:113Reply+1 for Configuration/Page.tsconfig -
Benni Mack uploaded patch set 4 01/19/22, 10:53
-
Benni Mack commented on patch set 5 01/19/22, 10:54
Published edit on patch set 4. -
Benni Mack commented on patch set 5 01/19/22, 10:56
AbstractServiceProvider.php:113ReplyHmm, I now use page.tsconfig, regarding lower/uppercase we can still "decide" :)
-
core-ci voted on patch set 4 V +1 01/19/22, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22254
-
core-ci voted on patch set 5 V +1 01/19/22, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22255
-
Christian Kuhn commented on patch set 5 01/19/22, 11:12
AbstractServiceProvider.php:113ReplyWill we have the same for user.tsconfig (to substitute conf-vars 'defaultUserTSconfig'?) Regarding casing: ... maybe we should simply accept *both* Page.tsconfig and page.tsconfig ... it's kinda hard to memorize casing details and existing files in Configuration/ tend to be UpperCamelCase ... -
Christian Kuhn commented on patch set 5 01/19/22, 11:26
page.tsconfig:1inline this, too?page.tsconfig:1ext:recordlist uses this in sysext/recordlist/Classes/Controller/RecordListController.php and sysext/recordlist/Classes/Browser/DatabaseBrowser.php I guess this section should be moved to ext:recordlist -
Benni Mack commented on patch set 5 01/19/22, 13:23
page.tsconfig:1Replywill dopage.tsconfig:1Replyyes. -
Benni Mack uploaded patch set 6 01/21/22, 20:34
-
Benni Mack uploaded patch set 7 01/21/22, 20:36
-
Benni Mack commented on patch set 6 01/21/22, 20:36
AbstractServiceProvider.php:113Replyuser.tsconfig will come at a later pointpage.tsconfig:1ReplyDonepage.tsconfig:1ReplyDone -
Benni Mack commented on patch set 7 01/21/22, 20:36
AbstractServiceProvider.php:113ReplyDone -
core-ci voted on patch set 6 V +1 01/21/22, 20:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22374
-
core-ci voted on patch set 7 V +1 01/21/22, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22375
-
Benjamin Franzke commented on patch set 7 CR +1 01/21/22, 20:51
Feature-96614-AutomaticInclusionOfPageTsConfigOfExtensions.rst:15typo -
Benni Mack commented on patch set 8 01/21/22, 20:54
Published edit on patch set 7. -
Benni Mack commented on patch set 8 01/21/22, 20:54
Feature-96614-AutomaticInclusionOfPageTsConfigOfExtensions.rst:15ReplyDone -
Christian Kuhn voted on patch set 8 V +1 CR +1 01/21/22, 21:01
-
Oli Bartsch voted on patch set 8 V +1 CR +1 01/21/22, 21:02
-
core-ci voted on patch set 8 V +1 01/21/22, 21:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22376
-
Benjamin Franzke uploaded patch set 9 01/21/22, 21:14
-
Benjamin Franzke commented on patch set 9 01/21/22, 21:15
ServiceProvider.php:340We need to var_export/require here as $cache->get delivers "<?php" prefix otherwise. Pushed patchset 9 to do so. -
Christian Kuhn commented on patch set 9 CR -1 01/21/22, 21:23
debugging a bit. temp -1, but will most likely upvote soon. -
Christian Kuhn voted on patch set 9 V +1 CR +1 01/21/22, 21:30
-
Stefan Bürk voted on patch set 9 V +1 CR +1 01/21/22, 21:30
-
core-ci voted on patch set 9 V +1 01/21/22, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22377
-
Benni Mack voted on patch set 9 V +2 CR +2 01/21/22, 21:33
-
Benni Mack merged patch set 10 01/21/22, 21:33