Review main Merged

73042[BUGFIX] Respect delimiter/enclosure in table ctype

Jochen Roth CR +2 V +2 Easy +25 −5 updated 03/28/22, 16:21

Commit message

In #95036 the table editor was moved from the separate
wizard to "inline". This implementation did not respect
"table_delimiter" and "table_enclosure".

This has been fixed by passing the delimiter and enclosure
to the table component and parse depending on the set values.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1117

  1. Jochen Roth uploaded patch set 1 01/17/22, 10:08

  2. core-ci voted on patch set 1 V -1 01/17/22, 10:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22178

  3. Jochen Roth uploaded patch set 2 01/17/22, 11:03

  4. core-ci voted on patch set 2 V -1 01/17/22, 11:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22180

  5. Jochen Roth uploaded patch set 3 01/17/22, 12:47

  6. core-ci voted on patch set 3 V +1 01/17/22, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22184

  7. Guido Schmechel updated the commit message in patch set 4 01/17/22, 13:24

  8. core-ci voted on patch set 4 V +1 01/17/22, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22185

  9. Nikita Hovratov uploaded patch set 5 01/22/22, 21:02

  10. core-ci voted on patch set 5 V +1 01/22/22, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22413

  11. Simon Schaufelberger uploaded patch set 6 03/22/22, 22:54

  12. Simon Schaufelberger commented on patch set 6 V +1 CR +1 03/22/22, 22:59

    works!
  13. core-ci voted on patch set 6 V +1 03/22/22, 23:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25061

  14. Christian Kuhn voted on patch set 6 V +2 CR +2 03/28/22, 15:57

  15. Oli Bartsch commented on patch set 6 03/28/22, 16:16

    table-wizard-element.ts:48

    No fallback here?
  16. Christian Kuhn commented on patch set 6 03/28/22, 16:20

    table-wizard-element.ts:48 Reply

    delimeter is always hand over as '|' by controller.
  17. Christian Kuhn merged patch set 7 03/28/22, 16:21